Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address AMO Review Concerns #1118

Merged
merged 13 commits into from Feb 1, 2012

Conversation

Projects
None yet
6 participants
@brendandahl
Copy link
Contributor

commented Jan 24, 2012

-Removes compatibility.js so we have less warnings.
-Gets rid of all the places we use innerHtml.
-Changes the add-on to use a stream converter instead of a content handler. This has the following pros:

  • We now run completely under normal content privileges.
  • The URL remains the same when clicking on a PDF url.
  • The google redirect issue is fixed #809

The cons:

  • We have to inline pdf.js into the extension and use the BlobBuilder due to not being able to load the worker with a resource:// url. This may actually be a bug in firefox, I'm not quite sure how that is suppose to work and I need to look into it more.

I've also stripped out all the private browsing and extension only storage stuff because this is no longer applicable because we run under content privileges.

Please download, build and try out the extension.

TODO: fix the anchor tag links so they show the correct URL. Add the url changes to browser history so the back/forward buttons work on the anchors.

@notmasteryet

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2012

@pdfjsbot test

@pdfjsbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 24, 2012

Processing command test by user notmasteryet. Queue size: 0

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/3625563.txt

[bot:processed:3625563]

@pdfjsbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 24, 2012

ERROR(s) found

ATTENTION: There was a snapshot difference:
http://184.73.87.52:8989/tests/178b89342af2185de7771fba8112cb92cd6dfaa9/reftest-analyzer.xhtml#web=/tests/178b89342af2185de7771fba8112cb92cd6dfaa9/eq.log

Output:

========== Killing any stray processes

========== Running garbage collector in /home/ubuntu/pdf.js-bot/tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone
Auto-merging Makefile
Auto-merging web/viewer.html
Auto-merging web/viewer.js

========== Running 'make lint'
gjslint --nojsdoc  src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js  web/compatibility.js web/viewer.js test/driver.js examples/helloworld/hello.js extensions/firefox/bootstrap.js extensions/firefox/components/pdfContentHandler.js  test/unit/crypto_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
----- FILE  :  /home/ubuntu/pdf.js-bot/tmp/tests/178b89342af2185de7771fba8112cb92cd6dfaa9/extensions/firefox/components/pdfContentHandler.js -----
Line 26, E:0012: Illegal semicolon after function declaration
Line 34, E:0001: Extra space at end of line
Line 53, E:0001: Extra space after "function"
Line 58, E:0001: Extra space after "function"
Line 64, E:0001: Extra space after "function"
Line 64, E:0110: Line too long (81 characters).
Line 66, E:0131: Single-quoted string preferred over double-quoted string.
Line 70, E:0001: Extra space after "function"
Line 75, E:0131: Single-quoted string preferred over double-quoted string.
Line 88, E:0001: Extra space after "function"

----- FILE  :  /home/ubuntu/pdf.js-bot/tmp/tests/178b89342af2185de7771fba8112cb92cd6dfaa9/src/core.js -----
Line 659, E:0010: (New error) Missing semicolon at end of line

Found 11 errors, including 1 new errors, in 2 files (29 files OK).
�
Some of the errors reported by GJsLint may be auto-fixable using the script
fixjsstyle. Please double check any changes it makes and report any bugs. The
script can be run by executing:

fixjsstyle --nojsdoc src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js web/compatibility.js web/viewer.js test/driver.js examples/helloworld/hello.js extensions/firefox/bootstrap.js extensions/firefox/components/pdfContentHandler.js test/unit/crypto_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js 
make: *** [lint] Error 3

========== Cloning reference images repo into test/ref/
Initialized empty Git repository in /home/ubuntu/pdf.js-bot/tmp/tests/178b89342af2185de7771fba8112cb92cd6dfaa9/test/ref/.git/

========== Checking for consistency with reference repo

========== Running 'make bot_test'
Xvfb: no process found
cd test; \
    python -u test.py \
    --browserManifestFile=resources/browser_manifests/browser_manifest.json \
    --manifestFile=test_manifest.json
Launching firefox
Launching chrome
TEST-PASS | eq test tracemonkey-eq | in chrome
TEST-PASS | eq test tracemonkey-eq | in firefox
TEST-PASS | forward-back-forward test tracemonkey-fbf | in chrome
TEST-PASS | load test html5-canvas-cheat-sheet-load | in chrome
TEST-PASS | forward-back-forward test tracemonkey-fbf | in firefox
TEST-PASS | load test html5-canvas-cheat-sheet-load | in firefox
TEST-PASS | eq test intelisa-eq | in chrome
TEST-PASS | eq test intelisa-eq | in firefox
TEST-PASS | load test pdfspec-load | in chrome
TEST-PASS | load test shavian-load | in chrome
TEST-PASS | eq test sizes | in chrome
TEST-PASS | eq test plusminus | in chrome
TEST-PASS | load test openoffice-pdf | in chrome
TEST-PASS | load test openofficecidtruetype-pdf | in chrome
TEST-PASS | load test openofficearabiccidtruetype-pdf | in chrome
TEST-PASS | load test arabiccidtruetype-pdf | in chrome
TEST-PASS | load test complexttffont-pdf | in chrome
TEST-PASS | eq test thuluthfont-pdf | in chrome
TEST-PASS | eq test freeculture | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in chrome
TEST-PASS | eq test i9-pdf | in chrome
TEST-PASS | load test hmm-pdf | in chrome
TEST-PASS | eq test rotation | in chrome
TEST-PASS | load test ecma262-pdf | in chrome
TEST-PASS | load test jai-pdf | in chrome
TEST-PASS | eq test cable | in chrome
TEST-PASS | eq test pdkids | in chrome
TEST-PASS | eq test artofwar | in chrome
TEST-PASS | eq test wdsg_fitc | in chrome
TEST-PASS | eq test unix01 | in chrome
TEST-PASS | eq test fit11-talk | in chrome
TEST-PASS | eq test fips197 | in chrome
TEST-PASS | load test txt2pdf | in chrome
TEST-PASS | load test f1040 | in chrome
TEST-PASS | load test hudsonsurvey | in chrome
TEST-PASS | eq test extgstate | in chrome
TEST-UNEXPECTED-FAIL | eq usmanm-bad | in chrome | rendering of page 3 != reference rendering
TEST-PASS | load test vesta-bad | in chrome
TEST-PASS | load test scan-bad | in chrome
TEST-PASS | load test ibwa-bad | in chrome
TEST-PASS | eq test tcpdf_033 | in chrome
TEST-PASS | eq test pal-o47 | in chrome
TEST-PASS | eq test simpletype3font | in chrome
TEST-PASS | eq test close-path-bug | in chrome
TEST-PASS | eq test alphatrans | in chrome
TEST-PASS | eq test devicen | in chrome
TEST-PASS | eq test cmykjpeg | in chrome
TEST-PASS | eq test protectip | in chrome
TEST-PASS | eq test piperine | in chrome
TEST-PASS | eq test issue840 | in chrome
TEST-UNEXPECTED-FAIL | eq bpl13210 | in chrome | rendering of page 4 != reference rendering
TEST-PASS | load test pdfspec-load | in firefox
TEST-PASS | load test shavian-load | in firefox
TEST-PASS | eq test sizes | in firefox
TEST-PASS | eq test plusminus | in firefox
TEST-PASS | load test openoffice-pdf | in firefox
TEST-PASS | load test openofficecidtruetype-pdf | in firefox
TEST-PASS | load test openofficearabiccidtruetype-pdf | in firefox
TEST-PASS | load test arabiccidtruetype-pdf | in firefox
TEST-PASS | load test complexttffont-pdf | in firefox
TEST-PASS | eq test thuluthfont-pdf | in firefox
TEST-PASS | eq test freeculture | in firefox
TEST-PASS | eq test wnv_chinese-pdf | in firefox
TEST-PASS | eq test tutorial | in chrome
TEST-PASS | eq test geothermal.pdf | in chrome
TEST-PASS | eq test i9-pdf | in firefox
TEST-PASS | eq test lista_preliminar | in chrome
TEST-PASS | eq test issue919 | in chrome
TEST-PASS | eq test issue918 | in chrome
TEST-PASS | eq test issue1001 | in chrome
TEST-PASS | eq test aboutstacks | in chrome
TEST-PASS | eq test smaskdim | in chrome
TEST-PASS | eq test type4psfunc | in chrome
TEST-PASS | load test ocs | in chrome
TEST-PASS | eq test issue1010 | in chrome
TEST-PASS | load test hmm-pdf | in firefox
TEST-PASS | eq test rotation | in firefox
TEST-PASS | eq test issue1015 | in chrome
TEST-PASS | load test liveprogramming | in chrome
TEST-PASS | eq test S2-eq | in chrome
TEST-PASS | eq test issue1055 | in chrome
TEST-PASS | eq test zerowidthline | in chrome
TEST-PASS | load test ecma262-pdf | in firefox
TEST-PASS | load test jai-pdf | in firefox
TEST-PASS | eq test cable | in firefox
TEST-PASS | eq test pdkids | in firefox
TEST-PASS | eq test artofwar | in firefox
TEST-PASS | eq test wdsg_fitc | in firefox
TEST-PASS | eq test unix01 | in firefox
TEST-PASS | eq test fit11-talk | in firefox
TEST-PASS | eq test fips197 | in firefox
TEST-PASS | load test txt2pdf | in firefox
TEST-PASS | load test f1040 | in firefox
TEST-PASS | load test hudsonsurvey | in firefox
TEST-PASS | eq test extgstate | in firefox
TEST-PASS | eq test usmanm-bad | in firefox
TEST-PASS | load test vesta-bad | in firefox
TEST-PASS | load test scan-bad | in firefox
TEST-PASS | load test ibwa-bad | in firefox
TEST-PASS | eq test tcpdf_033 | in firefox
TEST-PASS | eq test pal-o47 | in firefox
TEST-PASS | eq test simpletype3font | in firefox
TEST-PASS | eq test close-path-bug | in firefox
TEST-PASS | eq test alphatrans | in firefox
TEST-PASS | eq test devicen | in firefox
TEST-PASS | eq test cmykjpeg | in firefox
TEST-PASS | eq test protectip | in firefox
TEST-PASS | eq test piperine | in firefox
TEST-PASS | eq test issue840 | in firefox
TEST-PASS | eq test bpl13210 | in firefox
TEST-PASS | eq test tutorial | in firefox
TEST-PASS | eq test geothermal.pdf | in firefox
TEST-PASS | eq test lista_preliminar | in firefox
TEST-PASS | eq test issue919 | in firefox
TEST-PASS | eq test issue918 | in firefox
TEST-PASS | eq test issue1001 | in firefox
TEST-PASS | eq test aboutstacks | in firefox
TEST-PASS | eq test smaskdim | in firefox
TEST-PASS | eq test type4psfunc | in firefox
TEST-PASS | load test ocs | in firefox
TEST-PASS | eq test issue1010 | in firefox
TEST-PASS | eq test issue1015 | in firefox
TEST-PASS | load test liveprogramming | in firefox
TEST-PASS | eq test S2-eq | in firefox
TEST-PASS | eq test issue1055 | in firefox
TEST-PASS | eq test zerowidthline | in firefox

OHNOES!  Some tests failed!
  different ref/snapshot: 2
Process firefox is still running. Killing.
Runtime was 1529 seconds

========== Cleaning up
./run-test: line 206: 19155 Killed                  Xvfb :1 -screen 0 1280x1024x24 > /dev/null 2> /dev/null

All done.


_____________________________ stderr:

Bot response time: 26.70 mins

@brendandahl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2012

@pdfjsbot lint

@pdfjsbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 24, 2012

Processing command lint by user brendandahl. Queue size: 0

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/3626084.txt

[bot:processed:3626084]

@pdfjsbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 24, 2012

All tests passed.

Output:

========== Killing any stray processes

========== Running garbage collector in /home/ubuntu/pdf.js-bot/tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone
Auto-merging Makefile
Auto-merging web/viewer.html
Auto-merging web/viewer.js

========== Running 'make lint'
gjslint --nojsdoc  src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js  web/compatibility.js web/viewer.js test/driver.js examples/helloworld/hello.js extensions/firefox/bootstrap.js extensions/firefox/components/pdfContentHandler.js  test/unit/crypto_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
31 files checked, no errors found.

All done.


_____________________________ stderr:

Bot response time: 0.96 mins

@notmasteryet

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2012

Current regressions:

  • Download button does not work;
  • Opening internal links in the new tab does not work.

Also possible confusion from the user:

  • When file is uploaded (browse button), the address bar still points to initial pdf -- do we need to disable this functionallity for extension?

component {2278dfd0-b75c-11e0-8257-1ba3d93c9f1a} components/pdfContentHandler.js
contract @mozilla.org/uriloader/content-handler;1?type=application/pdf {2278dfd0-b75c-11e0-8257-1ba3d93c9f1a}
contract @mozilla.org/streamconv;1?from=application/pdf&to=*/* {2278dfd0-b75c-11e0-8257-1ba3d93c9f1a}

This comment has been minimized.

Copy link
@notmasteryet

notmasteryet Jan 24, 2012

Contributor

do we need to change GUID since contract is changed?

@arturadib

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2012

Tested make extesion on both Mac and Linux (bot), the build works on both.

+1 after fixing anchor tags and regressions pointed out by Yury. I also noticed the following (which might get fixed when we fix the Download button):

If you open a PDF from e.g. a Google result, then click on the Download button and hit the browser Back button twice, the URL goes back to the original one (e.g. the Google result URL), but the page content still displays the PDF.

@brendandahl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2012

I've thought of another possible issue with localStorage. Now its stored based on the domain the pdf is hosted, e.g. there's no longer a centralized store for all the pdf scroll/zoom information.

@brendandahl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2012

Everything should be working, however we still need to figure out how to verify the new events are coming from pdf.js which I have yet to figure out because the window.location now points to the pdf url.

@notmasteryet

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2012

Opening in new tab / bookmarking links in the thumbs view does not work.

watchWindows(function(window) {
window.addEventListener(PDFJS_EVENT_ID, messageCallback, false, true);
unload(function() {
window.removeEventListener(PDFJS_EVENT_ID, messageCallback, false, true);

This comment has been minimized.

Copy link
@brendandahl

brendandahl Jan 26, 2012

Author Contributor

TODO: Fix this line

@brendandahl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2012

@pdfjsbot test

@pdfjsbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 27, 2012

Processing command test by user brendandahl. Queue size: 0

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/3692257.txt

[bot:processed:3692257]

@pdfjsbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 27, 2012

All tests passed.

Output:

========== Killing any stray processes

========== Running garbage collector in /home/ubuntu/pdf.js-bot/tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone
Auto-merging Makefile
Auto-merging web/viewer.html
Auto-merging web/viewer.js

========== Running 'make lint'
gjslint --nojsdoc  src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js  web/compatibility.js web/viewer.js test/driver.js examples/helloworld/hello.js extensions/firefox/bootstrap.js extensions/firefox/components/PdfStreamConverter.js  test/unit/crypto_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
31 files checked, no errors found.

========== Cloning reference images repo into test/ref/
Initialized empty Git repository in /home/ubuntu/pdf.js-bot/tmp/tests/f46b0474ce4bad106f3c6dd813f23af8459e1479/test/ref/.git/

========== Checking for consistency with reference repo

========== Running 'make bot_test'
Xvfb: no process found
cd test; \
    python -u test.py \
    --browserManifestFile=resources/browser_manifests/browser_manifest.json \
    --manifestFile=test_manifest.json
Launching firefox
Launching chrome
TEST-PASS | eq test tracemonkey-eq | in chrome
TEST-PASS | eq test tracemonkey-eq | in firefox
TEST-PASS | forward-back-forward test tracemonkey-fbf | in chrome
TEST-PASS | load test html5-canvas-cheat-sheet-load | in chrome
TEST-PASS | forward-back-forward test tracemonkey-fbf | in firefox
TEST-PASS | load test html5-canvas-cheat-sheet-load | in firefox
TEST-PASS | eq test intelisa-eq | in chrome
TEST-PASS | eq test intelisa-eq | in firefox
TEST-PASS | load test pdfspec-load | in chrome
TEST-PASS | load test shavian-load | in chrome
TEST-PASS | eq test sizes | in chrome
TEST-PASS | eq test plusminus | in chrome
TEST-PASS | load test openoffice-pdf | in chrome
TEST-PASS | load test openofficecidtruetype-pdf | in chrome
TEST-PASS | load test openofficearabiccidtruetype-pdf | in chrome
TEST-PASS | load test arabiccidtruetype-pdf | in chrome
TEST-PASS | load test complexttffont-pdf | in chrome
TEST-PASS | eq test thuluthfont-pdf | in chrome
TEST-PASS | eq test freeculture | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in chrome
TEST-PASS | eq test i9-pdf | in chrome
TEST-PASS | load test hmm-pdf | in chrome
TEST-PASS | eq test rotation | in chrome
TEST-PASS | load test ecma262-pdf | in chrome
TEST-PASS | load test jai-pdf | in chrome
TEST-PASS | eq test cable | in chrome
TEST-PASS | eq test pdkids | in chrome
TEST-PASS | eq test artofwar | in chrome
TEST-PASS | eq test wdsg_fitc | in chrome
TEST-PASS | eq test unix01 | in chrome
TEST-PASS | eq test fit11-talk | in chrome
TEST-PASS | eq test fips197 | in chrome
TEST-PASS | load test txt2pdf | in chrome
TEST-PASS | load test f1040 | in chrome
TEST-PASS | load test hudsonsurvey | in chrome
TEST-PASS | eq test extgstate | in chrome
TEST-PASS | eq test usmanm-bad | in chrome
TEST-PASS | load test vesta-bad | in chrome
TEST-PASS | load test scan-bad | in chrome
TEST-PASS | load test ibwa-bad | in chrome
TEST-PASS | eq test tcpdf_033 | in chrome
TEST-PASS | eq test pal-o47 | in chrome
TEST-PASS | eq test simpletype3font | in chrome
TEST-PASS | eq test close-path-bug | in chrome
TEST-PASS | eq test alphatrans | in chrome
TEST-PASS | eq test devicen | in chrome
TEST-PASS | eq test cmykjpeg | in chrome
TEST-PASS | eq test protectip | in chrome
TEST-PASS | eq test piperine | in chrome
TEST-PASS | eq test issue840 | in chrome
TEST-PASS | eq test bpl13210 | in chrome
TEST-PASS | load test pdfspec-load | in firefox
TEST-PASS | load test shavian-load | in firefox
TEST-PASS | eq test sizes | in firefox
TEST-PASS | eq test plusminus | in firefox
TEST-PASS | load test openoffice-pdf | in firefox
TEST-PASS | load test openofficecidtruetype-pdf | in firefox
TEST-PASS | load test openofficearabiccidtruetype-pdf | in firefox
TEST-PASS | load test arabiccidtruetype-pdf | in firefox
TEST-PASS | eq test tutorial | in chrome
TEST-PASS | load test complexttffont-pdf | in firefox
TEST-PASS | eq test thuluthfont-pdf | in firefox
TEST-PASS | eq test geothermal.pdf | in chrome
TEST-PASS | eq test lista_preliminar | in chrome
TEST-PASS | eq test freeculture | in firefox
TEST-PASS | eq test issue919 | in chrome
TEST-PASS | eq test issue918 | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in firefox
TEST-PASS | eq test issue1001 | in chrome
TEST-PASS | eq test aboutstacks | in chrome
TEST-PASS | eq test smaskdim | in chrome
TEST-PASS | eq test type4psfunc | in chrome
TEST-PASS | eq test i9-pdf | in firefox
TEST-PASS | load test ocs | in chrome
TEST-PASS | eq test issue1010 | in chrome
TEST-PASS | load test hmm-pdf | in firefox
TEST-PASS | eq test rotation | in firefox
TEST-PASS | eq test issue1015 | in chrome
TEST-PASS | eq test issue1096 | in chrome
TEST-PASS | load test liveprogramming | in chrome
TEST-PASS | eq test S2-eq | in chrome
TEST-PASS | eq test issue1055 | in chrome
TEST-PASS | eq test zerowidthline | in chrome
TEST-PASS | load test ecma262-pdf | in firefox
TEST-PASS | load test jai-pdf | in firefox
TEST-PASS | eq test cable | in firefox
TEST-PASS | eq test pdkids | in firefox
TEST-PASS | eq test artofwar | in firefox
TEST-PASS | eq test wdsg_fitc | in firefox
TEST-PASS | eq test unix01 | in firefox
TEST-PASS | eq test fit11-talk | in firefox
TEST-PASS | eq test fips197 | in firefox
TEST-PASS | load test txt2pdf | in firefox
TEST-PASS | load test f1040 | in firefox
TEST-PASS | load test hudsonsurvey | in firefox
TEST-PASS | eq test extgstate | in firefox
TEST-PASS | eq test usmanm-bad | in firefox
TEST-PASS | load test vesta-bad | in firefox
TEST-PASS | load test scan-bad | in firefox
TEST-PASS | load test ibwa-bad | in firefox
TEST-PASS | eq test tcpdf_033 | in firefox
TEST-PASS | eq test pal-o47 | in firefox
TEST-PASS | eq test simpletype3font | in firefox
TEST-PASS | eq test close-path-bug | in firefox
TEST-PASS | eq test alphatrans | in firefox
TEST-PASS | eq test devicen | in firefox
TEST-PASS | eq test cmykjpeg | in firefox
TEST-PASS | eq test protectip | in firefox
TEST-PASS | eq test piperine | in firefox
TEST-PASS | eq test issue840 | in firefox
TEST-PASS | eq test bpl13210 | in firefox
TEST-PASS | eq test tutorial | in firefox
TEST-PASS | eq test geothermal.pdf | in firefox
TEST-PASS | eq test lista_preliminar | in firefox
TEST-PASS | eq test issue919 | in firefox
TEST-PASS | eq test issue918 | in firefox
TEST-PASS | eq test issue1001 | in firefox
TEST-PASS | eq test aboutstacks | in firefox
TEST-PASS | eq test smaskdim | in firefox
TEST-PASS | eq test type4psfunc | in firefox
TEST-PASS | load test ocs | in firefox
TEST-PASS | eq test issue1010 | in firefox
TEST-PASS | eq test issue1015 | in firefox
TEST-PASS | eq test issue1096 | in firefox
TEST-PASS | load test liveprogramming | in firefox
TEST-PASS | eq test S2-eq | in firefox
TEST-PASS | eq test issue1055 | in firefox
TEST-PASS | eq test zerowidthline | in firefox

All tests passed.
Process firefox is still running. Killing.
Runtime was 1556 seconds

========== Cleaning up
./run-test: line 206: 26481 Killed                  Xvfb :1 -screen 0 1280x1024x24 > /dev/null 2> /dev/null

All done.


_____________________________ stderr:

Bot response time: 27.16 mins

@brendandahl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2012

@notmasteryet @arturadib
This should be good for another review. It has changed again quite a bit so I'd recommend downloading and trying it out again.

download: function(data) {
Services.wm.getMostRecentWindow('navigator:browser').saveURL(data);
},
setDatabase: function() {

This comment has been minimized.

Copy link
@notmasteryet

notmasteryet Jan 31, 2012

Contributor

Missed data as parameter

This comment has been minimized.

Copy link
@brendandahl

brendandahl Feb 1, 2012

Author Contributor

fixed

this.actions = actions;
}
// Recieves an event and synchronously responds.
RequestListener.prototype.recieve = function(event) {

This comment has been minimized.

Copy link
@notmasteryet

notmasteryet Jan 31, 2012

Contributor

recieve => receive

(also comment above and calls below)

This comment has been minimized.

Copy link
@brendandahl

brendandahl Feb 1, 2012

Author Contributor

fixed

sed -i.bak '/PDFJSSCRIPT_REMOVE/d' viewer.html; \
sed -i.bak '/PDFJSSCRIPT_REMOVE_FIREFOX_EXTENSION/d' viewer.html; \
sed -i.bak '/PDFJSSCRIPT_INCLUDE_FIREFOX_EXTENSION/ r viewer-snippet-firefox-extension.html' viewer.html; \
rm -f *.bak;

This comment has been minimized.

Copy link
@kkujala

kkujala Jan 31, 2012

Contributor

It would be better to do it like this:
sed -i.bak '/PDFJSSCRIPT_INCLUDE_FIREFOX_EXTENSION/ r viewer-snippet-firefox-extension.html' viewer.html
@rm -f *.bak

This comment has been minimized.

Copy link
@brendandahl

brendandahl Feb 1, 2012

Author Contributor

I added the @ to the above cd since I want them to all happen in the same directory.

Makefile Outdated
sed -i.bak '/PDFJSSCRIPT_INCLUDE_FIREFOX_EXTENSION/ r viewer-snippet-firefox-extension.html' viewer.html; \
rm -f *.bak;
# We don't need pdf.js anymore since its inlined
rm -Rf $(FIREFOX_BUILD_CONTENT)/$(BUILD_DIR)/;

This comment has been minimized.

Copy link
@kkujala

kkujala Jan 31, 2012

Contributor

Also here:
@rm -Rf $(FIREFOX_BUILD_CONTENT)/$(BUILD_DIR)/

Otherwise this line won't get executed.

This comment has been minimized.

Copy link
@brendandahl

brendandahl Feb 1, 2012

Author Contributor

fixed

@arturadib

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2012

The URL navigation glitch is gone! Anchor links are working, including on the sidebar.

The addon overall seems to be working superbly here.

+1 from me, but since this is a big change let's wait for a +1 from Yury as well.

notmasteryet added a commit that referenced this pull request Feb 1, 2012

@notmasteryet notmasteryet merged commit 13f2074 into mozilla:master Feb 1, 2012

@qazedc

This comment has been minimized.

Copy link

commented Feb 1, 2012

time for submitting it to AMO again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.