Add a heuristic to scale even single-char text, when the horizontal/vertical scaling differs significantly (issue 11713) #11727
Conversation
Snuffleupagus
force-pushed
the
issue-11713
branch
from
adfda60
to
5b3ed42
Compare
Snuffleupagus
changed the title
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8ff60b721cec1b1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/99b2ddbcc3cfb97/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8ff60b721cec1b1/output.txt Total script time: 19.77 mins
Image differences available at: http://54.67.70.0:8877/8ff60b721cec1b1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/99b2ddbcc3cfb97/output.txt Total script time: 60.00 mins |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a28a955b519a2cc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1573370c8979132/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a28a955b519a2cc/output.txt Total script time: 19.62 mins
Image differences available at: http://54.67.70.0:8877/a28a955b519a2cc/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/1573370c8979132/output.txt Total script time: 25.29 mins
Image differences available at: http://54.215.176.217:8877/1573370c8979132/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
issue-11713
branch
2 times, most recently
from
f758ca8
to
e6b52ed
Compare
Snuffleupagus
force-pushed
the
issue-11713
branch
from
e6b52ed
to
a7cd628
Compare
…ertical scaling differs significantly (issue 11713) At this point in time, compared to when the "ignore single-char" code was added, we *should* generally be doing a much better job of combining text into as few chunks as possible. However, there's still bad cases where we're not able to combine text as much as one would like, which is why I'm *not* proposing to simply measure/scale all text. Instead this patch will to only measure/scale single-char text in cases where the horizontal/vertical scale is off significantly, since that's were you'd expect bad text-selection behaviour otherwise. Note that most of the movement caused by this patch is with Type3 fonts, which is a somewhat special font type and one where our current text-selection behaviour is probably the least good.
Snuffleupagus
force-pushed
the
issue-11713
branch
from
a7cd628
to
91efde5
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1c74e5065aeb03e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/72902861493165d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/1c74e5065aeb03e/output.txt Total script time: 19.69 mins
Image differences available at: http://54.67.70.0:8877/1c74e5065aeb03e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/72902861493165d/output.txt Total script time: 24.97 mins
Image differences available at: http://54.215.176.217:8877/72902861493165d/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dd11396f8517b4f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/dd11396f8517b4f/output.txt Total script time: 2.54 mins Published |
|
Seems to work nicely. Thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5f73755419684e9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/c3975c9a8d2635e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5f73755419684e9/output.txt Total script time: 18.17 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/c3975c9a8d2635e/output.txt Total script time: 23.23 mins
|
At this point in time, compared to when the "ignore single-char" code was added, we should generally be doing a much better job of combining text into as few chunks as possible.
However, there's still bad cases where we're not able to combine text as much as one would like, which is why I'm not proposing to simply measure/scale all text. Instead this patch will to only measure/scale single-char text in cases where the horizontal/vertical scale is off significantly, since that's were you'd expect bad text-selection behaviour otherwise.
Note that most of the movement caused by this patch is with Type3 fonts, which is a somewhat special font type and one where our current text-selection behaviour is probably the least good.
Fixes #11713