A couple of (small) tweaks of the AnnotationStorage (PR 12173 follow-up)
#12192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-up) - Initialize the `AnnotationStorage`-instance, on `PDFDocumentProxy`, lazily. - Change the `AnnotationStorage` to use a `Map` internally, rather than a regular Object (simplifies the following points). - Let `AnnotationStorage.getAll` return `null` when there's no data stored, to avoid unnecessary parsing on the worker-thread. This ought to "just work", since the worker-thread code *should* already handle the `!annotationStorage` case everywhere. - Add a new `AnnotationStorage.size` getter, to be able to easily tell if there's any data stored.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ffcd72c3033e823/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/74a867e08353a38/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/74a867e08353a38/output.txt Total script time: 3.85 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ffcd72c3033e823/output.txt Total script time: 5.08 mins
|
timvandermeij
approved these changes
Aug 11, 2020
|
Looks good! |
timvandermeij
added
annotations
form-acroform
Gecko 81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnotationStorage-instance, onPDFDocumentProxy, lazily.AnnotationStorageto use aMapinternally, rather than a regular Object (simplifies the following points).AnnotationStorage.getAllreturnnullwhen there's no data stored, to avoid unnecessary parsing on the worker-thread. This ought to "just work", since the worker-thread code should already handle the!annotationStoragecase everywhere.AnnotationStorage.sizegetter, to be able to easily tell if there's any data stored.