Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer - Draw text if a font can't be loaded #12711

Closed
wants to merge 2 commits into from

Conversation

dsherret
Copy link

@dsherret dsherret commented Dec 9, 2020

Wanted to at least get the conversation started about #4244. I don't really understand the code in this area, but here's a patch that at least draws text if a font can't be loaded which was important for my purposes.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some drive-by comments, but I don't know enough about this particular part of the codebase to review it completely.

src/display/font_loader.js Outdated Show resolved Hide resolved
src/display/font_loader.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants