Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFA -- Load fonts permanently from the pdf #13146

Merged
merged 1 commit into from Apr 16, 2021
Merged

XFA -- Load fonts permanently from the pdf #13146

merged 1 commit into from Apr 16, 2021

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Mar 26, 2021 •
edited

  • Different fonts can be used in xfa and some of them are embedded in the pdf.
  • Load all the fonts in window.document.

Snuffleupagus
Snuffleupagus requested changes Mar 26, 2021
View reviewed changes
src/core/document.js Outdated Show resolved Hide resolved
src/core/fonts.js Outdated Show resolved Hide resolved
src/display/api.js Outdated Show resolved Hide resolved
src/display/api.js Outdated Show resolved Hide resolved
src/display/api.js Outdated Show resolved Hide resolved
src/display/api.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Mar 26, 2021
View reviewed changes
src/core/document.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

PR #13172 got merged today which provides the keepLoadedFonts parameter for PDFDocumentProxy.cleanup so that this PR can simply use that to make this one smaller.

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/3a97d6f68dec24e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/41ed27a2d126ecd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/3a97d6f68dec24e/output.txt

Total script time: 25.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/3a97d6f68dec24e/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/41ed27a2d126ecd/output.txt

Total script time: 29.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/41ed27a2d126ecd/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus requested changes Apr 15, 2021
View reviewed changes
src/core/document.js Outdated Show resolved Hide resolved
src/core/worker.js Outdated Show resolved Hide resolved
src/display/font_loader.js Show resolved Hide resolved
@calixteman calixteman force-pushed the xfa_fonts branch 2 times, most recently from 7509ac0 to 2a72340 Compare April 15, 2021 15:38
Snuffleupagus
Snuffleupagus reviewed Apr 15, 2021
View reviewed changes
src/core/document.js Outdated Show resolved Hide resolved
@calixteman @Snuffleupagus
XFA -- Load fonts permanently from the pdf
7e95790 
  - Different fonts can be used in xfa and some of them are embedded in the pdf.
  - Load all the fonts in window.document.

Update src/core/document.js

Co-authored-by: Jonas Jenwald <jonas.jenwald@gmail.com>

Update src/core/worker.js

Co-authored-by: Jonas Jenwald <jonas.jenwald@gmail.com>
@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0876eb8f2c5b6cd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 1

Live output at: http://3.101.106.178:8877/589b92b5b1c01f8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/0876eb8f2c5b6cd/output.txt

Total script time: 25.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/0876eb8f2c5b6cd/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/589b92b5b1c01f8/output.txt

Total script time: 29.49 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/589b92b5b1c01f8/reftest-analyzer.html#web=eq.log

@brendandahl brendandahl merged commit ac3fa1e into mozilla:master Apr 16, 2021
calixteman added a commit to calixteman/pdf.js that referenced this pull request May 17, 2021
@calixteman
XFA - Don't move glyphes in private area with non-truetype fonts
a74d192 
  - it has been done in PR mozilla#13146 but only for truetype fonts.
@calixteman calixteman mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus requested changes

@brendandahl brendandahl brendandahl requested changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@calixteman @timvandermeij @brendandahl @pdfjsbot @Snuffleupagus