Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert objects to sets in places where we only track keys #13184

Merged
merged 2 commits into from Apr 7, 2021

Conversation

timvandermeij
Copy link
Contributor

The commit messages contain more information about the individual changes.

…om an object to a set

We only want to track XRef starting points instead of actual data, so
using a set conveys that intention more clearly and is slightly more
efficient.
…js`, from an object to a set

We only want to track page numbers instead of actual data, so using a
set conveys that intention more clearly and is slightly more efficient.
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8f1ba6415442f9f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/8f1ba6415442f9f/output.txt

Total script time: 4.36 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a25c7383c940b54/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://3.101.106.178:8877/ef68567ed49c60b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/a25c7383c940b54/output.txt

Total script time: 25.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/a25c7383c940b54/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/ef68567ed49c60b/output.txt

Total script time: 28.56 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/ef68567ed49c60b/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@timvandermeij timvandermeij merged commit 336ebd6 into mozilla:master Apr 7, 2021
@timvandermeij timvandermeij deleted the sets branch April 7, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants