Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some deprecated code #13186

Merged
merged 3 commits into from Apr 7, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

Please refer to the individual commit messages for additional details.

…vent (PR 12788 follow-up)

These properties have been deprecated in two releases now, hence we shouldn't need to keep this code around.
…llow-up)

This method has been deprecated in two releases now, hence we shouldn't need to keep this code around.
… 12759 follow-up)

While this method has only been deprecated in one releases now, the `AnnotationStorage`-functionality is new enough that third-party implementations hopefully don't rely heavily on it just yet. (And removing this quickly should help reduce the likelihood that someone starts using it.)
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9aea9105dbd289b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/9aea9105dbd289b/output.txt

Total script time: 4.39 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/21176c1890e2442/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/427d935ac27670a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/21176c1890e2442/output.txt

Total script time: 25.48 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/21176c1890e2442/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/427d935ac27670a/output.txt

Total script time: 28.49 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/427d935ac27670a/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 5945f7c into mozilla:master Apr 7, 2021
@timvandermeij
Copy link
Contributor

Nice cleanup!

@Snuffleupagus Snuffleupagus deleted the rm-deprecated-code branch April 7, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants