Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy-match the fontName, for TrueType Collection fonts, where the "name"-table is wrong (issue 13193) #13194

Merged
merged 1 commit into from Apr 7, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

The fontName, as defined in the PDF document, cannot be found in any of the "name"-tables in the TrueType Collection font. To work-around that, this patch adds a fallback code-path to allow using an approximately matching fontName rather than outright failing.

Fixes #13193

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/744f9feb9f15bd8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/aa6d7c7eafc7cb8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/744f9feb9f15bd8/output.txt

Total script time: 24.82 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/744f9feb9f15bd8/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/aa6d7c7eafc7cb8/output.txt

Total script time: 28.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/aa6d7c7eafc7cb8/reftest-analyzer.html#web=eq.log

…ame"-table is wrong (issue 13193)

The fontName, as defined in the PDF document, cannot be found in *any* of the "name"-tables in the TrueType Collection font. To work-around that, this patch adds a *fallback* code-path to allow using an approximately matching fontName rather than outright failing.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1a4282452a886b2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/1a4282452a886b2/output.txt

Total script time: 4.40 mins

Published

@timvandermeij timvandermeij merged commit 6429ccc into mozilla:master Apr 7, 2021
@timvandermeij
Copy link
Contributor

Looks good to me; thanks! (And amazing how PDF generators found yet another way to mess things up.)

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://3.101.106.178:8877/1fe8f5e9945d66d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7d8b113fece605f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/7d8b113fece605f/output.txt

Total script time: 22.83 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/1fe8f5e9945d66d/output.txt

Total script time: 26.43 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatError: TrueType Collection does not contain "DCWGQU+CambriaMath" font
3 participants