[api-minor] A couple of smaller PDFPageProxy.getStructTree fixes (PR 13171 follow-up)
#13221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` set (PR 13171 follow-up)
Open http://localhost:8888/web/viewer.html?file=/test/pdfs/pdf.pdf#disableStream=true&disableAutoFetch=true and observe the following message in the console (repeated for each page of the document):
```
Uncaught (in promise)
Object { message: "Missing data [19787293, 19787294)", name: "UnknownErrorException", details: "MissingDataException: Missing data [19787293, 19787294)", stack: "BaseExceptionClosure@http://localhost:8888/src/shared/util.js:458:29\n@http://localhost:8888/src/shared/util.js:462:3\n" }
```
…an an empty structTree, for documents without any accessibility data (PR 13171 follow-up) This is first of all consistent with existing API-methods, where we return `null` when the data in question doesn't exist. Secondly, it should also be (slightly) more efficient since there's less dummy-data that we need to transfer between threads. Finally, this prevents us from adding an empty/unnecessary span to *every* single page even in documents without any structure tree data.
Snuffleupagus
force-pushed
the
structTree-fixes
branch
from
3a5ffd4
to
5adee0c
Compare
|
Add a couple of missing API unit-tests for the structure tree functionality. /botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/0d9a162fb5d5a64/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ed4e95181eeb847/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ed4e95181eeb847/output.txt Total script time: 3.68 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/0d9a162fb5d5a64/output.txt Total script time: 5.92 mins
|
timvandermeij
approved these changes
Apr 11, 2021
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
getStructTreewon't break withdisableAutoFetch = trueset (PR 13171 follow-up)Open http://localhost:8888/web/viewer.html?file=/test/pdfs/pdf.pdf#disableStream=true&disableAutoFetch=true and observe the following message in the console (repeated for each page of the document):
[api-minor] Let
PDFPageProxy.getStructTreereturnnull, rather than an empty structTree, for documents without any accessibility data (PR 13171 follow-up)This is first of all consistent with the existing API, where we return
nullwhen the data in question doesn't exist. Secondly, it should also be (slightly) more efficient since there's less dummy-data that we need to transfer between threads.Finally, this prevents us from adding an empty/unnecessary span to every single page even in documents without any structure tree data.