Split the classes in src/core/obj.js into separate files
#13235
Conversation
|
I think this is a good idea now that the size and functionality of |
The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality. In order to improve readability and make it easier to navigate through the code, this patch moves the `ObjectLoader` into its own file.
The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality. In order to improve readability and make it easier to navigate through the code, this patch moves the `FileSpec` into its own file.
…file The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality. In order to improve readability and make it easier to navigate through the code, this patch moves `NameTree`/`NumberTree` into its own file.
The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality. In order to improve readability and make it easier to navigate through the code, this patch moves the `XRef` into its own file.
Now that only the `Catalog` remains in this file, after the previous patches, it makes sense to rename the file to reduce confusion.
Snuffleupagus
force-pushed
the
split-core-obj
branch
from
63b300b
to
1d6d476
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/64722e6dcfbc7d3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/7480760df88b181/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/64722e6dcfbc7d3/output.txt Total script time: 25.58 mins
Image differences available at: http://54.67.70.0:8877/64722e6dcfbc7d3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/7480760df88b181/output.txt Total script time: 28.93 mins
Image differences available at: http://3.101.106.178:8877/7480760df88b181/reftest-analyzer.html#web=eq.log |
|
Nice work! |
The size of the
src/core/obj.jsfile has increased slowly over the years, and it also contains a fair amount of distinct functionality.In order to improve readability and make it easier to navigate through the code, these patches move (and re-factor) the different classes into their own files.
In order to simplify reviewing: I'd suggest looking at one commit at a time, and using the
?w=1flag to reduce the size of the diffs.