Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-config-prettier/eslint-plugin-unicorn packages to their latest versions #13240

Merged
merged 1 commit into from Apr 14, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

Both of these ESLint "helpers" has increased their major version numbers, which npm update doesn't handle automatically (since that could cause errors), hence this patch which updates them manually.

https://www.npmjs.com/package/eslint-config-prettier
https://www.npmjs.com/package/eslint-plugin-unicorn

…heir latest versions

Both of these ESLint "helpers" has increased their *major* version numbers, which `npm update` doesn't handle automatically (since that could cause errors), hence this patch which updates them manually.

https://www.npmjs.com/package/eslint-config-prettier
https://www.npmjs.com/package/eslint-plugin-unicorn
@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/974e66bf56e8bd5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/cec428cd4e8790b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/974e66bf56e8bd5/output.txt

Total script time: 2.60 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/cec428cd4e8790b/output.txt

Total script time: 3.78 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit eddb908 into mozilla:master Apr 14, 2021
@timvandermeij
Copy link
Contributor

Thank you for updating this!

@Snuffleupagus Snuffleupagus deleted the update-eslint-helpers branch April 14, 2021 19:10
@Snuffleupagus
Copy link
Collaborator Author

There's now only two packages left where we're on old major versions:

  • SystemJS, which we don't really care about since the intention is to get rid of it completely as soon as https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 is fixed.
  • yargs, which we however should updated. I've looked at that briefly, at least twice, and wasn't really able to immediately figure out exactly what changes were necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants