Convert done callbacks to async/await in test/unit/api_spec.js
#13253
Conversation
|
/botio unittest |
There was a problem hiding this comment.
That's a lot of code, but hopefully I've not missed anything :-)
This looks mostly good, but I think that there's some additional clean-up possible if you're touching most of the file anyway.
I'd suggest re-factoring the promise usage a bit more while you're at it, please see the inline comment which shows one such example.
Also, can you please fix the mistake I made in https://github.com/mozilla/pdf.js/blob/master/test/unit/api_spec.js#L2116?
timvandermeij
force-pushed
the
unit-test-async-await-pt3
branch
from
9f8272f
to
130c254
Compare
|
The review comments have been addressed. Given the size of the file, it might be easiest to review the interdiff and ignoring all changes not in |
|
/botio unittest |
timvandermeij
force-pushed
the
unit-test-async-await-pt3
branch
2 times, most recently
from
1d9bd7d
to
77d8161
Compare
|
I have also fixed the mistake you mentioned now. /botio unittest |
timvandermeij
force-pushed
the
unit-test-async-await-pt3
branch
from
77d8161
to
c2f3a71
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b0589c0902b763f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/1e850d4f92066cc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b0589c0902b763f/output.txt Total script time: 3.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/1e850d4f92066cc/output.txt Total script time: 5.60 mins
|
This is one of the three remaining files, and since it's quite big it's done separately from the other ones for easier review. It's recommended to use the
?w=1flag to make reviewing much easier because of all indentation changes.