A couple of small scripting/XFA-related tweaks in the worker-code #13254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
scripting-misc-fixes
branch
from
cd01ae1
to
65cc0ef
Compare
- Use `PDFManager.ensureDoc`, rather than `PDFManager.ensure`, in a couple of spots in the code. If there exists a short-hand format, we should obviously use it whenever possible. - Fix a unit-test helper, to account for the previous changes. (Also, converts a function to be `async` instead.) - Add one more exists-check in `PDFDocument.loadXfaFonts`, which I missed to suggest in PR 13146, to prevent any possible errors if the method is ever called in a situation where it shouldn't be. Also, print a warning if the actual font-loading fails since that could help future debugging. (Finally, reduce overall indentation in the loop.) - Slightly unrelated, but make a small tweak of a comment in `src/core/fonts.js` to reduce possible confusion.
Snuffleupagus
force-pushed
the
scripting-misc-fixes
branch
from
65cc0ef
to
f560fe6
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9c8b6b7762d10a7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/660ac80b36a0ce0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9c8b6b7762d10a7/output.txt Total script time: 25.90 mins
Image differences available at: http://54.67.70.0:8877/9c8b6b7762d10a7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/660ac80b36a0ce0/output.txt Total script time: 28.54 mins
Image differences available at: http://3.101.106.178:8877/660ac80b36a0ce0/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Apr 17, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
PDFManager.ensureDoc, rather thanPDFManager.ensure, in a couple of spots in the code. If there exists a short-hand format, we should obviously use it wherever possible.Fix a unit-test helper, to account for the previous changes. (Also, converts a function to be
asyncinstead.)Add one more exists-check in
PDFDocument.loadXfaFonts, which I missed to suggest in PR 13146, to prevent any future errors if the method is ever called in a situation where it shouldn't be.Also, print a warning if the actual font-loading fails since that could help future debugging. (Finally, reduce overall indentation in the loop.)
Slightly unrelated, but make a small tweak of a comment in
src/core/fonts.jsto reduce possible confusion.Slightly smaller/simpler diff with https://github.com/mozilla/pdf.js/pull/13254/files?w=1