Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Fix several issues found in pdf in #13269 #13274

Merged
merged 1 commit into from May 5, 2021

Conversation

calixteman
Copy link
Contributor

  • app.alert and few other function can use an object as parameter ({cMsg: ...});
  • support app.alert with a question and a yes/no answer;
  • update field siblings when one is changed in an action;
  • stop calculation if calculate is set to false in the middle of calculations;
  • get a boolean for checkboxes when they've been set through annotationStorage instead of a string.

@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7d63daa0a615576/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/b126448751a821e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/7d63daa0a615576/output.txt

Total script time: 25.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/7d63daa0a615576/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/b126448751a821e/output.txt

Total script time: 28.89 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/b126448751a821e/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c25822e7329cfd5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/3fe184549e7d3c9/output.txt

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.67.70.0:8877/6f1605247dc9e6c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/f8783178131e648/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/c25822e7329cfd5/output.txt

Total script time: 4.24 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/3fe184549e7d3c9/output.txt

Total script time: 5.96 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/6f1605247dc9e6c/output.txt

Total script time: 3.96 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/f8783178131e648/output.txt

Total script time: 5.18 mins

  • Integration Tests: FAILED

  - app.alert and few other function can use an object as parameter ({cMsg: ...});
  - support app.alert with a question and a yes/no answer;
  - update field siblings when one is changed in an action;
  - stop calculation if calculate is set to false in the middle of calculations;
  - get a boolean for checkboxes when they've been set through annotationStorage instead of a string.
@brendandahl
Copy link
Contributor

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/da18a0c5abe5348/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/e2eca412e78474e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/da18a0c5abe5348/output.txt

Total script time: 4.22 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 4, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/e2eca412e78474e/output.txt

Total script time: 6.00 mins

  • Integration Tests: FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants