Convert the code in src/display/canvas.js to use standard classes
#13300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of *a lot* of boilerplate that stems from our old way of simulating classes, and it actually reduces the filesize noticeably. For e.g. `gulp mozcentral`, the *built* `pdf.js` files decreases from `318 404` to `314 722` bytes (~1 percent) with this patch.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c3f316af7ac1a29/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/903d9719b7b69ed/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c3f316af7ac1a29/output.txt Total script time: 25.61 mins
Image differences available at: http://54.67.70.0:8877/c3f316af7ac1a29/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/903d9719b7b69ed/output.txt Total script time: 29.45 mins
Image differences available at: http://3.101.106.178:8877/903d9719b7b69ed/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Apr 27, 2021
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a lot of boilerplate that stems from our old way of simulating classes, and it actually reduces the filesize noticeably.
For e.g.
gulp mozcentral, the builtpdf.jsfiles decreases from318 404to314 722bytes (~1 percent) with this patch.Much smaller/simpler diff with https://github.com/mozilla/pdf.js/pull/13300/files?w=1