Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS -- add support for page property in field #13319

Merged
merged 1 commit into from May 3, 2021

Conversation

calixteman
Copy link
Contributor

Page property is the page where the field is.
Currently the page is undefined which can lead to errors (see bug 1708641).

src/core/document.js Outdated Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the final comments addressed and all tests passing; thank you!

src/core/document.js Outdated Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ab259f2db4766a9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/3a61955fd4a5f59/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/ab259f2db4766a9/output.txt

Total script time: 25.81 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/ab259f2db4766a9/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/3a61955fd4a5f59/output.txt

Total script time: 29.84 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/3a61955fd4a5f59/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 3f187c2 into mozilla:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants