Add a new BaseStream.getString(...) method to replace manual bytesToString(BaseStream.getBytes(...)) calls
#13320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
bytesToString(BaseStream.getBytes(...)) callsBaseStream.getString(...) method to replace manual bytesToString(BaseStream.getBytes(...)) calls
…ToString(BaseStream.getBytes(...))` calls Given that the `bytesToString(BaseStream.getBytes(...))` pattern is somewhat common throughout the `src/core/` code, it cannot hurt to add a new `BaseStream`-method which handles that case internally.
…eateFontFaceRule` The `this.data` property is, when defined, sent from the worker-thread as a `Uint8Array` and there's thus no reason to re-initialize the TypedArray here. Note also the `FontFaceObject.createNativeFontFace` method just above, where we simply use `this.data` as-is. The explanation for this code looking like it does is, as is often the case, for historical reasons. Originally we only supported `@font-face`, before the Font Loading API existed, and back then we also polyfilled TypedArrays (using regular Arrays) which should explain this particular line of code.
Snuffleupagus
force-pushed
the
BaseStream-getString
branch
from
4c67fc4
to
90b5fcb
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9d85254fc5c2168/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/171fe34438791ac/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9d85254fc5c2168/output.txt Total script time: 25.70 mins
Image differences available at: http://54.67.70.0:8877/9d85254fc5c2168/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/171fe34438791ac/output.txt Total script time: 29.66 mins
Image differences available at: http://3.101.106.178:8877/171fe34438791ac/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 2, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
bytesToString(BaseStream.getBytes(...))pattern is somewhat common throughout thesrc/core/code, it cannot hurt to add a newBaseStream-method which handles that case internally.