Fix highlighting of search results when the textLayer contains br-elements (PR 13257 follow-up, issue 13323)
#13324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
textLayer-br-style
branch
from
f528f47
to
c37db9b
Compare
Snuffleupagus
changed the title
textLayer contains br-elements (PR 13323 follow-up, issue 13323)textLayer contains br-elements (PR 13257 follow-up, issue 13323)
…-elements (PR 13257 follow-up, issue 13323) Apparently we need to layout `br`-elements in the same *exact* way as the regular `span`-elements which contain the text-content.
Snuffleupagus
force-pushed
the
textLayer-br-style
branch
from
c37db9b
to
883ce5d
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7f448ef54845c57/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7f448ef54845c57/output.txt Total script time: 4.37 mins Published |
|
Both issues in #13323 are fixed thanks to this patch. |
calixteman
approved these changes
May 2, 2021
timvandermeij
approved these changes
May 2, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we need to layout
br-elements in the same exact way as the regularspan-elements which contain the text-content.Fixes #13323