[web/debugger.js] Enable the ESLint no-var rule
#13333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, removes a couple of unnecessary local variables in the `Stepper.breakIt` method. Finally, this patch also disables the ESLint `no-var` rule, in preparation for the next patch, for a couple of data-structures that need to remain globally available.
These changes were made *mostly* automatically, using `gulp lint --fix`, with the following manual changes:
```diff
diff --git a/web/debugger.js b/web/debugger.js
index 1cda4066e..6f8b4a9f0 100644
--- a/web/debugger.js
+++ b/web/debugger.js
@@ -264,10 +264,9 @@ const Stepper = (function StepperClosure() {
}
if ("length" in args) {
// array
- let simpleArgs = [],
- i,
- ii;
- const MAX_ITEMS = 10;
+ const MAX_ITEMS = 10,
+ simpleArgs = [];
+ let i, ii;
for (i = 0, ii = Math.min(MAX_ITEMS, args.length); i < ii; i++) {
simpleArgs.push(simplifyArgs(args[i]));
}
@@ -511,11 +510,8 @@ window.PDFBug = (function PDFBugClosure() {
return {
tools: [FontInspector, StepperManager, Stats],
enable(ids) {
- let all = false,
- tools = this.tools;
- if (ids.length === 1 && ids[0] === "all") {
- all = true;
- }
+ const all = ids.length === 1 && ids[0] === "all";
+ const tools = this.tools;
for (let i = 0; i < tools.length; ++i) {
const tool = tools[i];
if (all || ids.includes(tool.id)) {
```
Snuffleupagus
changed the title
no-var rule
Snuffleupagus
force-pushed
the
debugger-no-var
branch
from
aea24d5
to
d99bc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were made mostly automatically, using
gulp lint --fix, with the following manual changes: