Remove unnecessary closure in the src/core/font_renderer.js file
#13341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With modern JavaScript modules, where you explicitly list the properties that should be exported, it's no longer necessary to wrap *all* of the code within one file into a top-level closure.[1] This patch reduces the size, of even the *built* `pdf.worker.js` file, since there's now a lot less unnecessary whitespace. --- [1] For files which contain *different* functionality, some closures may however still make sense in order to separate the code. It might be possible to remove some of those cases later, e.g. once private class fields becomes generally available/usable in browsers.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/29d15b6449db9c0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/c6ec4265d1ab080/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/29d15b6449db9c0/output.txt Total script time: 26.12 mins
Image differences available at: http://54.67.70.0:8877/29d15b6449db9c0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/c6ec4265d1ab080/output.txt Total script time: 29.56 mins
Image differences available at: http://3.101.106.178:8877/c6ec4265d1ab080/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 7, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With modern JavaScript modules, where you explicitly list the properties that should be exported, it's no longer necessary to wrap all of the code within one file into a top-level closure.[1]
This patch reduces the size, of even the built
pdf.worker.jsfile, since there's now a lot less unnecessary whitespace.[1] For files which contain different functionality, some closures may however still make sense in order to separate the code.
It might be possible to remove some of those cases later, e.g. once private class fields becomes generally available/usable in browsers.