Only include the renderer-preference in builds where SVGGraphics is defined
#13360
Conversation
…is defined After PR 13117 it's now (finally) possible for *different* build targets to specify individual options/preferences, and we can utilize that to only expose the `renderer`-preference in builds where `SVGGraphics` is actually defined. Note that for e.g. `MOZCENTRAL`-builds, trying to enable SVG-rendering will throw immediately and the preference thus doesn't make sense to include there. Also, update the dummy `SVGGraphics` to use a class, tweak the `PDFJSDev`-check in `src/display/svg.js` to agree fully with the option/preference, and remove an unnecessary `eslint-disable`.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d1d16ef71f91a3c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d1d16ef71f91a3c/output.txt Total script time: 4.34 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/33d5341cb3c1fcd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/76c8530b2fd42b8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/33d5341cb3c1fcd/output.txt Total script time: 26.03 mins
Image differences available at: http://54.67.70.0:8877/33d5341cb3c1fcd/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/76c8530b2fd42b8/output.txt Total script time: 29.02 mins
Image differences available at: http://3.101.106.178:8877/76c8530b2fd42b8/reftest-analyzer.html#web=eq.log |
|
Thanks! |
After PR #13117 it's now (finally) possible for different build targets to specify individual options/preferences, and we can utilize that to only expose the
renderer-preference in builds whereSVGGraphicsis actually defined.Note that for e.g.
MOZCENTRAL-builds, trying to enable SVG-rendering will throw immediately and the preference thus doesn't make sense to include there.Also, update the dummy
SVGGraphicsto use a class, tweak thePDFJSDev-check insrc/display/svg.jsto agree fully with the option/preference, and remove an unnecessaryeslint-disable.