Enable the no-var linting rule in src/core/bidi.js

[timvandermeij]

This is done automatically with gulp lint --fix and the following manual changes:

diff --git a/src/core/bidi.js b/src/core/bidi.js
index e9e0a7217..32691c0c6 100644
--- a/src/core/bidi.js
+++ b/src/core/bidi.js
@@ -82,7 +82,8 @@ function isEven(i) {
 }

 function findUnequal(arr, start, value) {
-  for (var j = start, jj = arr.length; j < jj; ++j) {
+  let j, jj;
+  for (j = start, jj = arr.length; j < jj; ++j) {
     if (arr[j] !== value) {
       return j;
     }
@@ -251,15 +252,14 @@ function bidi(str, startLevel, vertical) {
   for (i = 0; i < strLength; ++i) {
     if (types[i] === "EN") {
       // do before
-      var j;
-      for (j = i - 1; j >= 0; --j) {
+      for (let j = i - 1; j >= 0; --j) {
         if (types[j] !== "ET") {
           break;
         }
         types[j] = "EN";
       }
       // do after
-      for (j = i + 1; j < strLength; ++j) {
+      for (let j = i + 1; j < strLength; ++j) {
         if (types[j] !== "ET") {
           break;
         }

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://54.67.70.0:8877/d38d40f7235eac5/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://3.101.106.178:8877/92024bbf2034835/output.txt

[Snuffleupagus]

Looks good to me, thank you!

---

I believe that this means that only the test-folder is left to fix now, which is great :-)

[timvandermeij]

Yes, in the src folder only https://github.com/mozilla/pdf.js/blob/master/src/core/evaluator.js#L15 is left after that change got reverted, but other than that the rule is now enabled everywhere there :-)

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/d38d40f7235eac5/output.txt

Total script time: 26.07 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/d38d40f7235eac5/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/92024bbf2034835/output.txt

Total script time: 29.46 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/92024bbf2034835/reftest-analyzer.html#web=eq.log