Fix a few *safe* ESLint no-var failures in src/core/evaluator.js (13371 follow-up)
#13387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(13371 follow-up)
As can be seen in PR 13371, some of the `no-var` changes in the `PartialEvaluator.{getOperatorList, getTextContent}` methods caused errors in `gulp server`-mode.
However, there's a handful of instances of `var` in other methods which should be completely *safe* to convert since there's no strange scope-issues present in that code.
Snuffleupagus
force-pushed
the
evaluator-some-no-var
branch
from
99b6d3e
to
718f7bf
Compare
Snuffleupagus
changed the title
no-var failures (13371 follow-up)src/core/evaluator.js (13371 follow-up)
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e0a33828aa686e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/e2506339332dced/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/e0a33828aa686e0/output.txt Total script time: 26.17 mins
Image differences available at: http://54.67.70.0:8877/e0a33828aa686e0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/e2506339332dced/output.txt Total script time: 30.01 mins
Image differences available at: http://3.101.106.178:8877/e2506339332dced/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 16, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen in PR #13371, some of the
no-varchanges in thePartialEvaluator.{getOperatorList, getTextContent}methods caused errors ingulp server-mode.However, there's a handful of instances of
varin other methods which should be completely safe to convert since there's no strange scope-issues present in that code.