Tweak adjustToUnicode to allow extending a built-in /ToUnicode map
#13393
Conversation
Snuffleupagus
force-pushed
the
adjustToUnicode-hasIncludedToUnicodeMap
branch
5 times, most recently
from
b7d7b16
to
8b99730
Compare
Snuffleupagus
force-pushed
the
adjustToUnicode-hasIncludedToUnicodeMap
branch
3 times, most recently
from
48c4e38
to
bc27e66
Compare
Snuffleupagus
force-pushed
the
adjustToUnicode-hasIncludedToUnicodeMap
branch
3 times, most recently
from
6c2948e
to
7337987
Compare
Snuffleupagus
force-pushed
the
adjustToUnicode-hasIncludedToUnicodeMap
branch
from
7337987
to
9b75271
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d64def1b46a8c14/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/c68e82fc1793cfd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d64def1b46a8c14/output.txt Total script time: 26.41 mins
Image differences available at: http://54.67.70.0:8877/d64def1b46a8c14/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/c68e82fc1793cfd/output.txt Total script time: 29.82 mins
Image differences available at: http://3.101.106.178:8877/c68e82fc1793cfd/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
adjustToUnicode-hasIncludedToUnicodeMap
branch
from
9b75271
to
3c2c5fd
Compare
*This is somewhat similiar to the recent changes, in PR 13277, for fonts with an /Encoding entry.* Currently we're *completely* ignoring the `builtInEncoding`, from the font data itself, for fonts which have a built-in /ToUnicode map. While it (obviously) doesn't seem like a good idea in general to simply overwrite existing built-in /ToUnicode entries, it should however not hurt to use the `builtInEncoding` to supplement *missing* /ToUnicode entires.
This removes the need to *manually* wrap all return values in a Promise.
…ToGlyphId` for TrueType fonts Note that all standard Encodings have the same length (i.e. `256` elements) and that missing entries are always represented by empty strings, hence why a separate exists-check isn't necessary in the `baseEncoding` case.
Rather than having to create and check a *separate* `ToUnicodeMap` to handle these cases, we can simply use the `fallbackToUnicode`-data (when it exists) to directly supplement *missing* /ToUnicode entires in the regular `ToUnicodeMap` instead.
Snuffleupagus
force-pushed
the
adjustToUnicode-hasIncludedToUnicodeMap
branch
from
3c2c5fd
to
229a49b
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/09d22e2fbb9ef7c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/1d0c5fda3eec8be/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/09d22e2fbb9ef7c/output.txt Total script time: 27.39 mins
Image differences available at: http://54.67.70.0:8877/09d22e2fbb9ef7c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/1d0c5fda3eec8be/output.txt Total script time: 31.32 mins
Image differences available at: http://3.101.106.178:8877/1d0c5fda3eec8be/reftest-analyzer.html#web=eq.log |
This is somewhat similiar to the recent changes, in PR #13277, for fonts with an /Encoding entry.
Currently we're completely ignoring the
builtInEncoding, from the font data itself, for fonts which have a built-in /ToUnicode map.While it (obviously) doesn't seem like a good idea in general to simply overwrite existing built-in /ToUnicode entries, it should however not hurt to use the
builtInEncodingto supplement missing /ToUnicode entires.