Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Fix issues in text selection #13424

Merged
merged 1 commit into from Oct 18, 2021
Merged

Commits on Oct 17, 2021

  1. Fix issues in text selection

      - PR mozilla#13257 fixed a lot of issues but not all and this patch aims to fix almost all remaining issues.
      - the idea in this new patch is to compare position of new glyph with the last position where a glyph has been drawn;
        - no space are "drawn": it just moves the cursor but they aren't added in the chunk;
        - so this way a space followed by a cursor move can be treated as only one space: it helps to merge all spaces into one.
      - to make difference between real spaces and tracking ones, we used a factor of the space width (from the font)
        - it was a pretty good idea in general but it fails with some fonts where space was too big:
        - in Poppler, they're using a factor of the font size: this is an excellent idea (<= 0.1 * fontSize implies tracking space).
    calixteman committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    61d1063 View commit details
    Browse the repository at this point in the history