Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Add a storage to save fields values #13427

Merged
merged 1 commit into from May 28, 2021

Conversation

calixteman
Copy link
Contributor

  • this is required to be able to print (or save) a document. Some pages can be unloaded (because pdf.js is lazy) and this storage will help to save their data in order to resuse them when printing or just when displaying a page again.

src/display/xfa_layer.js Outdated Show resolved Hide resolved
src/display/xfa_layer.js Outdated Show resolved Hide resolved
@brendandahl
Copy link
Contributor

Will this be needed if we keep all pages in cache?

@Snuffleupagus
Copy link
Collaborator

Will this be needed if we keep all pages in cache?

That would be breaking some very old/basic assumptions in the viewer, since only one-page documents are ever guaranteed to be fully rendered at all times. Relaxing that assumption could be quite bad in the general case, for e.g. memory usage and performance, for anything except very short documents and as far as I can tell there's no guarantee that all XFA-documents are indeed "short".

…le to print (or save) a document. Some pages can be unloaded (because pdf.js is lazy) and this storage will help to save their data in order to resuse them when printing or just when displaying a page again.
@calixteman calixteman reopened this May 25, 2021
@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ccff9114cf59b4e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/327c651165c3cba/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/ccff9114cf59b4e/output.txt

Total script time: 26.04 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/ccff9114cf59b4e/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/327c651165c3cba/output.txt

Total script time: 30.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/327c651165c3cba/reftest-analyzer.html#web=eq.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants