Re-factor the charsCache on Font-instances
#13443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `charsCache` is initialized *lazily*, which considering that it just contains a simple `Object` doesn't seem entirely necessary. This first of all forces us to do repeated exists-checks in the `Font.charsToGlyphs` method, and secondly the similar/related `glyphCache` is already initialized eagerly. Furthermore, this patch also does a bit of clean-up in the `Font.charsToGlyphs` method since this code is quite old.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/aea4341b5fc77b1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/acf8651ccca399c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/aea4341b5fc77b1/output.txt Total script time: 25.69 mins
Image differences available at: http://54.67.70.0:8877/aea4341b5fc77b1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/acf8651ccca399c/output.txt Total script time: 29.80 mins
Image differences available at: http://3.101.106.178:8877/acf8651ccca399c/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 28, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
charsCacheis initialized lazily, which considering that it just contains a simpleObjectdoesn't seem entirely necessary. This first of all forces us to do repeated exists-checks in theFont.charsToGlyphsmethod, and secondly the similar/relatedglyphCacheis already initialized eagerly.Furthermore, this patch also does a bit of clean-up in the
Font.charsToGlyphsmethod since this code is quite old.