Fix Postscript name in font to avoid bug when saving in pdf #13445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/20c6d4a1b436825/output.txt |
Snuffleupagus
approved these changes
May 27, 2021
src/core/fonts.js
Outdated
| @@ -722,6 +722,11 @@ function createPostTable(properties) { | |||
| ); // maxMemType1 | |||
| } | |||
|
|
|||
| function makePostscriptName(name) { | |||
There was a problem hiding this comment.
Nit: I'd probably call this createPostscriptName for improved consistency, since all of the surrounding functions use that pattern.
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/20c6d4a1b436825/output.txt Total script time: 25.82 mins
Image differences available at: http://54.67.70.0:8877/20c6d4a1b436825/reftest-analyzer.html#web=eq.log |
- for xfa rendering, fonts are loaded and used in html;
- when printed and saved in pdf, on linux, Firefox uses cairo backend
- when subsetting a font, cairo uses the font postscript name and when this one is empty that leads to a bug
(the append at https://github.com/freedesktop/cairo/blob/63f0d6268469dcd12316ea405a026f4be900dd79/src/cairo-cff-subset.c#L2049 is failing because of null length)
- so this patch adds a postscript name to the font to make cairo happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the append at https://github.com/freedesktop/cairo/blob/63f0d6268469dcd12316ea405a026f4be900dd79/src/cairo-cff-subset.c#L2049 is failing because of null length)