Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some deprecated code from the viewer #14623

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

  • Revert "[GENERIC viewer] Add fallback logic for the old PDFPageView.update method signature"

    This reverts commit 8466204, since it's now been included in three official releases.

  • Remove the deprecated PDFFindController.executeCommand method

    This partially reverts commit fa8c0ef, since it's now been included in two official releases.

…update` method signature"

This reverts commit 8466204, since it's now been included in three official releases.
This *partially* reverts commit fa8c0ef, since it's now been included in two official releases.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Mar 2, 2022

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/712d6970b4d703b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 2, 2022

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9fb4336c5695bbd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 2, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/712d6970b4d703b/output.txt

Total script time: 4.07 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 2, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/9fb4336c5695bbd/output.txt

Total script time: 6.77 mins

  • Integration Tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Mar 2, 2022

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0b617afbd76f082/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 2, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0b617afbd76f082/output.txt

Total script time: 2.54 mins

Published

@timvandermeij timvandermeij merged commit 038c832 into mozilla:master Mar 2, 2022
@timvandermeij
Copy link
Contributor

Nice clean-up!

@Snuffleupagus Snuffleupagus deleted the viewer-deprecated-cleanup branch March 3, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants