Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the loca table endOffset, of the "first" glyph, correctly (issue 14618) #14629

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

When there are multiple empty glyphs at the start of the data, ensure that the "first" glyph gets a correct endOffset to avoid skipping it during parsing in the sanitizeGlyph function.

…issue 14618)

When there are *multiple* empty glyphs at the start of the data, ensure that the "first" glyph gets a correct `endOffset` to avoid skipping it during parsing in the `sanitizeGlyph` function.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/487c23ea5734542/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8b3a474e79f1c14/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/487c23ea5734542/output.txt

Total script time: 23.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/487c23ea5734542/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Mar 3, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/8b3a474e79f1c14/output.txt

Total script time: 26.30 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/8b3a474e79f1c14/reftest-analyzer.html#web=eq.log

@skivol
Copy link

skivol commented Mar 4, 2022

These changes worked fine for 2 original pdf files that had this issue as well 🥇👍

@brendandahl brendandahl merged commit 3b6d689 into mozilla:master Mar 5, 2022
@brendandahl
Copy link
Contributor

Looks good, thanks!

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/128fcb3598c82f2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7fbb5138b0e54f6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/128fcb3598c82f2/output.txt

Total script time: 21.03 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 5, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/7fbb5138b0e54f6/output.txt

Total script time: 21.31 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-14618 branch March 5, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text is not rendered correctly (namely, zeroes are missing)
4 participants