Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace XMLHttpRequest usage with the Fetch API in Driver._quit #14636

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

This is another step in what'll hopefully become a series of patches to implement PR #14287 in smaller steps.

This is another step in what'll hopefully become a series of patches to implement PR 14287 in smaller steps.
@Snuffleupagus
Copy link
Collaborator Author

/botio browsertest

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9e73525a4e79d2a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/709a76319f20e69/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/9e73525a4e79d2a/output.txt

Total script time: 20.27 mins

  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/709a76319f20e69/output.txt

Total script time: 21.40 mins

  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/709a76319f20e69/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 3e593cf into mozilla:master Mar 6, 2022
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the Driver-quit-fetch branch March 6, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants