Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper private methods in web/{pdf_cursor_tools,pdf_find_bar,secondary_toolbar}.js #14637

Merged
merged 3 commits into from
Mar 6, 2022

Conversation

timvandermeij
Copy link
Contributor

No description provided.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2bd1f74226b1447/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/2bd1f74226b1447/output.txt

Total script time: 2.84 mins

Published

@Snuffleupagus
Copy link
Collaborator

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/efb497f5d8e5fa5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/fee39c1f6dfae5d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/fee39c1f6dfae5d/output.txt

Total script time: 4.17 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 6, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/efb497f5d8e5fa5/output.txt

Total script time: 7.64 mins

  • Integration Tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks for improving this!

@Snuffleupagus Snuffleupagus merged commit c1f73b1 into mozilla:master Mar 6, 2022
@timvandermeij timvandermeij deleted the web-private branch March 6, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants