Simplify the PDFDocument constructor
#14648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally the code in the `src/`-folder was shared between the main/worker-threads, and back then it probably made sense that the `PDFDocument` constructor accepted different arguments. However, for many years we've not been passing anything *except* Streams to `PDFDocument` and we should thus be able to slightly simplify that code. Note that for e.g. unit-tests of this code, using either a `NullStream` or a `StringStream` works just fine.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d8c7ddbfbbb26ba/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d5780fa67b6c948/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d5780fa67b6c948/output.txt Total script time: 23.42 mins
Image differences available at: http://54.241.84.105:8877/d5780fa67b6c948/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d8c7ddbfbbb26ba/output.txt Total script time: 26.05 mins
|
timvandermeij
approved these changes
Mar 9, 2022
|
Makes sense; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the code in the
src/-folder was shared between the main/worker-threads, and back then it probably made sense that thePDFDocumentconstructor accepted different arguments.However, for many years we've not been passing anything except Streams to
PDFDocumentand we should thus be able to slightly simplify that code. Note that for e.g. unit-tests of this code, using either aNullStreamor aStringStreamworks just fine.