Convert the BasePreferences class to use private fields
#14665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that none of these fields were ever intended to be accessed directly from the *outside*, since that will lead to inconsistent/broken state, we can use modern ECMAScript features to ensure that they are indeed private.
…failed
This patch fixes an old inconsistency, when using `BasePreferences.{reset, set}`, where the internal Preference values would be kept even if writing them to storage failed.
Snuffleupagus
force-pushed
the
Preferences-private
branch
from
0fc2e88
to
3274972
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9b66a2d767ea265/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7cd533a946d4b4b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9b66a2d767ea265/output.txt Total script time: 3.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7cd533a946d4b4b/output.txt Total script time: 7.20 mins
|
timvandermeij
approved these changes
Mar 13, 2022
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the
BasePreferencesclass to use private fieldsGiven that none of these fields were ever intended to be accessed directly from the outside, since that will lead to inconsistent/broken state, we can use modern ECMAScript features to ensure that they are indeed private.
Revert Preferences to their previous values, when writing to storage failed
This patch fixes an old inconsistency, when using
BasePreferences.{reset, set}, where the internal Preference values would be kept even if writing them to storage failed.