Change the type of the container property, in the TextLayerRenderParameters typedef (issue 14716)
#14717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters` typedef (issue 14716) Given that the textLayer-code has been using a `DocumentFragment` ever since PR 3356 (back in 2013), simply updating the type of the `container` property should be fine. This patch also tries to, ever so slightly, improve the grammar of a couple of other properties in the typedef.
timvandermeij
approved these changes
Mar 27, 2022
|
Thanks for updating this! |
rousek
pushed a commit
to signosoft/pdf.js
that referenced
this pull request
Aug 10, 2022
In PR mozilla#14717, the type was changed from a HTMLElement to a DocumentFragment. This broke TypeScript projects that use a HTMLElement container. To remedy this, we extend the type of container to also include HTMLElement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the textLayer-code has been using a
DocumentFragmentever since PR #3356 (back in 2013), simply updating the type of thecontainerproperty should be fine.This patch also tries to, ever so slightly, improve the grammar of a couple of other properties in the typedef.