Re-factor the isLittleEndian/isEvalSupported caching
#14751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is very old, hence we should be able to improve the caching a little bit with modern JavaScript features.
We don't need to first check if the Dictionary contains the key, since trying to get a non-existent key simply returns `undefined` and we're already ensuring that the value is a boolean. Furthermore, we shouldn't need to worry about the `Object.prototype` containing enumerable properties since the checks (in `src/core/worker.js`) done for `Array.prototype` *indirectly* also cover `Object`s. (Keep in mind that an `Array` is just a special kind of `Object` in JavaScript.)
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1db9fd777e5d5e8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/daadd7aeba3fe84/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1db9fd777e5d5e8/output.txt Total script time: 24.44 mins
Image differences available at: http://54.241.84.105:8877/1db9fd777e5d5e8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/daadd7aeba3fe84/output.txt Total script time: 26.76 mins
Image differences available at: http://54.193.163.58:8877/daadd7aeba3fe84/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Apr 8, 2022
|
Looks good; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factor the
isLittleEndian/isEvalSupportedcachingThis functionality is very old, hence we should be able to improve the caching a little bit with modern JavaScript features.
Slightly simplify the
Catalog._readMarkInfomethodWe don't need to first check if the Dictionary contains the key, since trying to get a non-existent key simply returns
undefinedand we're already ensuring that the value is a boolean.Furthermore, we shouldn't need to worry about the
Object.prototypecontaining enumerable properties since the checks (insrc/core/worker.js) done forArray.prototypeindirectly also coverObjects. (Keep in mind that anArrayis just a special kind ofObjectin JavaScript.)