Simplify handling of requestFullscreen errors in PDFPresentationMode
#14765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since quite some time the `Element.requestFullscreen()` method has been returning a Promise, see https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen#return_value Hence we can utilize that to detect failures to enter fullscreen-mode, and remove our old `setTimeout`-based hacks that were used for this purpose. According to the MDN compatibility data, see https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen#browser_compatibility, all browsers that we support have implemented this functionality. (Note that after PR 14606, we no longer support PresentationMode in Safari.)
…PresentationModeState` With the changes in the previous patch, we can simplify the state-tracking by using the `PresentationModeState`-values directly in the `PDFPresentationMode` class.
Snuffleupagus
changed the title
requestFullscreen errors in PDFPresentationMode
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7d1d5686f02fd15/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7d1d5686f02fd15/output.txt Total script time: 2.63 mins Published |
timvandermeij
approved these changes
Apr 10, 2022
|
Much better; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify handling of
requestFullscreenerrors inPDFPresentationModeSince quite some time the
Element.requestFullscreen()method has been returning a Promise, see https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen#return_valueHence we can utilize that to detect failures to enter fullscreen-mode, and remove our old
setTimeout-based hacks that were used for this purpose.According to the MDN compatibility data, see https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen#browser_compatibility, all browsers that we support have implemented this functionality. (Note that after PR Only support the standard, unprefixed, Fullscreen API in the default viewer #14606, we no longer support PresentationMode in Safari.)
Re-factor how
PDFPresentationMode, internally, tracks the currentPresentationModeStateWith the changes in the previous patch, we can simplify the state-tracking by using the
PresentationModeState-values directly in thePDFPresentationModeclass.