Always remove the sidebarMoving CSS class when the sidebar is closed
#14770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
sidebarContainer-transitionend
branch
from
4edf7d6
to
647e4c9
Compare
When the viewer becomes narrow enough that the sidebar is overlaying the document, which means that the `viewerContainer` is not moving when opening/closing the sidebar, we're currently not removing the `sidebarMoving` CSS class as intended. While this doesn't cause any *visible* issues, it's nonetheless wrong and should be fixed.
Snuffleupagus
force-pushed
the
sidebarContainer-transitionend
branch
from
647e4c9
to
0fbe583
Compare
Snuffleupagus
changed the title
sidebarMoving CSS class when the sidebar is closedsidebarMoving CSS class when the sidebar is closed
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/000e7869378aedd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/000e7869378aedd/output.txt Total script time: 2.66 mins Published |
timvandermeij
approved these changes
Apr 14, 2022
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the viewer becomes narrow enough that the sidebar is overlaying the document, which means that the
viewerContaineris not moving when opening/closing the sidebar, we're currently not removing thesidebarMovingCSS class as intended.While this doesn't cause any visible issues, it's nonetheless wrong and should be fixed.