Remove/simplify some CSS rules #14772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For the findbar/secondaryToolbar case, the `min-width` rule doesn't really make sense since it's way too small to be useful. Furthermore, the findbar is already specifying its own `min-width` and the secondaryToolbar will (thanks to its buttons) receive a correct/useful width. - The pageNumber-input already has an *explicit* `width` set, hence setting the `min-width` rule as well is completely unnecessary. - The treeItem-links are supposed to *compute* their `min-width`, and the static value was only added as a fallback for older browsers without `calc()` support.
With just a couple of exceptions, for the `thumbnailView`, all of the sidebarViews share the same basic styling which thus allows for some simplification.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/a462a4e7cd7fa14/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a462a4e7cd7fa14/output.txt Total script time: 2.72 mins Published |
timvandermeij
approved these changes
Apr 14, 2022
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
min-widthCSS rulesFor the findbar/secondaryToolbar case, the
min-widthrule doesn't really make sense since it's way too small to be useful. Furthermore, the findbar is already specifying its ownmin-widthand the secondaryToolbar will (thanks to its buttons) receive a correct/useful width.The pageNumber-input already has an explicit
widthset, hence setting themin-widthrule as well is completely unnecessary.The treeItem-links are supposed to compute their
min-width, and the static value was only added as a fallback for older browsers withoutcalc()support.Reduce (some) duplication in the CSS rules for the sidebarViews
With just a couple of exceptions, for the
thumbnailView, all of the sidebarViews share the same basic styling which thus allows for some simplification.