Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and translations #14860

Merged
merged 2 commits into from
May 1, 2022
Merged

Update dependencies and translations #14860

merged 2 commits into from
May 1, 2022

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Apr 30, 2022 •
edited

The commit messages contain more information about the individual changes.

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/159f11e9ccd7788/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/adc9a0145a52ad2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/159f11e9ccd7788/output.txt

Total script time: 26.83 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 7
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/159f11e9ccd7788/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/adc9a0145a52ad2/output.txt

Total script time: 48.80 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 729
  different ref/snapshot: 80

Image differences available at: http://54.193.163.58:8877/adc9a0145a52ad2/reftest-analyzer.html#web=eq.log

@Snuffleupagus

This comment was marked as outdated.

Sign in to view
@Snuffleupagus
Copy link
Collaborator

I've just tested this patch locally, since I didn't have time for that last night, and it seems that I can no longer reproduce #14860 (comment) now :-)

Unfortunately it looks like Chrome still time-out on Windows, so it looks like we'll have to leave the current hacks in.

Also, assuming that there's actually any changes, mind adding a commit with any npm audit fix updates?

@timvandermeij
Update dependencies to the most recent versions
dacd61f 
There are two notable changes here:

- `dommatrix` is a major version upgrade, but looking through the commit
  history of their `package.json` file at https://github.com/thednp/dommatrix/commits/master/package.json
  (due to the lack of a changelog) I couldn't find any breaking changes.
- `es-module-shims` is a regular update, but it was previously pinned
  for causing intermittent breakage when running the unit tests in a
  browser manually. Fortunately this cannot be reproduced anymore with
  the most recent version, so we can also put the caret back now.
@timvandermeij
Update translations to the most recent versions
58fed00
@timvandermeij
Copy link
Contributor Author

I have removed the revert commits and updated the commit message for es-module-shims. I checked npm audit fix and found that it doesn't change any dependencies, so that's not necessary this time.

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2022

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/202b7c019e2680d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2022

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cea00f9eebe88b7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2022

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/cea00f9eebe88b7/output.txt

Total script time: 26.83 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/cea00f9eebe88b7/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2022

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/202b7c019e2680d/output.txt

Total script time: 26.87 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

Snuffleupagus
Snuffleupagus approved these changes May 1, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@Snuffleupagus Snuffleupagus merged commit 4bd5d98 into mozilla:master May 1, 2022
@timvandermeij timvandermeij deleted the updates branch May 1, 2022 11:44
@Snuffleupagus
Copy link
Collaborator

@timvandermeij For me the updated es-module-shims package is now instead breaking the development viewer, in both Firefox and Chrome, when opened with e.g. http://localhost:8888/web/viewer.html?file=/test/pdfs/pdf.pdf#disableHistory=true

Successfully compiled asm.js code (total compilation time 8ms) es-module-shims.js
Uncaught Error: Unsupported Content-Type "text/html" loading http://localhost:8888/web/viewer.html?file=/test/src/pdf.js imported from http://localhost:8888/web/app.js. Modules must be served with a valid MIME type like application/javascript.
    fetchModule http://localhost:8888/node_modules/es-module-shims/dist/es-module-shims.js:635
es-module-shims.js:635:13
Uncaught (in promise) Error: Unsupported Content-Type "text/html" loading http://localhost:8888/web/viewer.html?file=/test/src/pdf.js imported from http://localhost:8888/web/app.js. Modules must be served with a valid MIME type like application/javascript.
    fetchModule http://localhost:8888/node_modules/es-module-shims/dist/es-module-shims.js:635
14 es-module-shims.js:635:13

Do you perhaps have time to submit a revert patch for that?

@timvandermeij timvandermeij mentioned this pull request May 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
dependencies other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timvandermeij @pdfjsbot @Snuffleupagus