Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoded dest-strings in /GoTo destination dictionaries (issue 14864) #14865

Merged
merged 1 commit into from
May 2, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Interestingly enough this appears to be the very first case of encoded dest-strings, in /GoTo destination dictionaries, that we've actually come across. What's really fascinating is that it's less than a week after issue #14847, given that these issues are somewhat similar.

… 14864)

Interestingly enough this appears to be the very first case of *encoded* dest-strings, in /GoTo destination dictionaries, that we've actually come across. What's really fascinating is that it's less than a week after issue 14847, given that these issues are *somewhat* similar.
@Snuffleupagus Snuffleupagus linked an issue May 2, 2022 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2022

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f9070057af8a8f5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2022

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/51b1e3b1167c318/output.txt

@calixteman
Copy link
Contributor

It reminds me this article: https://www.pdfa.org/understanding-utf-8-in-pdf-2-0/

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f9070057af8a8f5/output.txt

Total script time: 3.53 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/51b1e3b1167c318/output.txt

Total script time: 6.62 mins

  • Unit Tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Snuffleupagus Snuffleupagus merged commit db12492 into mozilla:master May 2, 2022
@Snuffleupagus Snuffleupagus deleted the issue-14864 branch May 2, 2022 11:00
@mirabilos
Copy link

Not sure these are encoded right, though (unless there’s another commit between 2.13.216 and master that does this; I just retrofitted this commit on top of the prebuilt release to test this):

Screenshot_20220503_153507
Screenshot_20220503_153500

@mirabilos
Copy link

I would expect “H%C3%A4ndel”, for example.

(This is unrelated to the other issue, I didn’t know about it, and I had to kick Tₑχ/LᴬTᴇΧ really hard to even generate this (read: I’m doing the UTF-16 encoding outside, in a script).)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF bookmarks in hyperlinks not UTF-8-encoded
4 participants