[JS] Fix few bugs present in the pdf for issue #14862 #14869

calixteman · 2022-05-02T17:54:19Z

since resetForm function reset a field value a calculateNow is consequently triggered.
But the calculate callback can itself call resetForm, hence an infinite recursive loop.
So basically, prevent calculeNow to be triggered by itself.
in Firefox, the letters entered in some fields were duplicated: "AaBb" instead of "AB".
It was mainly because beforeInput was triggering a Keystroke which was itself triggering
an input value update and then the input event was triggered.
So in order to avoid that, beforeInput calls preventDefault and then it's up to the JS to
handle the event.
fields have a property valueAsString which returns the value as a string. In the
implementation it was wrongly used to store the formatted value of a field (2€ when the user
entered 2). So this patch implements correctly valueAsString.
non-rendered fields can be updated in using JS but when they're, they must take some properties
in the annotationStorage. It was implemented for field values, but it wasn't for
display, colors, ...
it fixes Too much recursion in a form with some embedded JS #14862 and Set Textfield-Value with Javascript not working as expected #14705.

Snuffleupagus

r=me, with the comments fixed and all tests passing; thank you!

src/display/annotation_storage.js

src/scripting_api/event.js

src/scripting_api/doc.js

test/integration/scripting_spec.js

Snuffleupagus · 2022-05-03T07:55:31Z

test/test_manifest.json

+   },
+   {  "id": "issue14862",
+      "file": "pdfs/issue14862.pdf",
+      "md5": "e64d7f2dac11e124971f1901ba59cf9c",
+      "rounds": 1,
+      "link": false,
+      "type": "other"
+    },
+    {  "id": "issue14705",
+       "file": "pdfs/issue14705.pdf",
+       "md5": "4f203d3e60bde33103a92e24d7e5eb73",
+       "rounds": 1,
+       "link": false,
+       "type": "other"
+    }


Please remove this, since it's not necessary when you're adding the test-cases directly to the repository.

Note that the purpose of "other" was just to allow using linked test-cases for unit/integration-tests without also needing to have them as reference tests. Hence an entry in this file is only needed in the "link": true, case.

src/display/annotation_layer.js

calixteman · 2022-05-03T09:57:54Z

/botio unittest

pdfjsbot · 2022-05-03T09:57:56Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/7edb241c1f50f24/output.txt

pdfjsbot · 2022-05-03T09:57:56Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/1aeb25dc2e5fd08/output.txt

pdfjsbot · 2022-05-03T10:10:19Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7edb241c1f50f24/output.txt

Total script time: 3.50 mins

Unit Tests: FAILED

pdfjsbot · 2022-05-03T10:19:45Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/1aeb25dc2e5fd08/output.txt

Total script time: 6.26 mins

Unit Tests: FAILED

calixteman · 2022-05-03T13:34:45Z

/botio unittest

pdfjsbot · 2022-05-03T13:34:46Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dd8144ecbd65ea5/output.txt

pdfjsbot · 2022-05-03T13:34:46Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/574e1a7c83b63e7/output.txt

pdfjsbot · 2022-05-03T13:38:03Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/dd8144ecbd65ea5/output.txt

Total script time: 3.27 mins

Unit Tests: Passed

calixteman · 2022-05-03T13:38:45Z

/botio integrationtest

pdfjsbot · 2022-05-03T13:38:46Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a3e46fd96e54bae/output.txt

pdfjsbot · 2022-05-03T13:38:46Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/a56d22d3d60e57c/output.txt

src/scripting_api/doc.js

pdfjsbot · 2022-05-03T13:41:07Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/574e1a7c83b63e7/output.txt

Total script time: 6.33 mins

Unit Tests: Passed

pdfjsbot · 2022-05-03T13:43:28Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a3e46fd96e54bae/output.txt

Total script time: 4.69 mins

Integration Tests: FAILED

pdfjsbot · 2022-05-03T13:48:41Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a56d22d3d60e57c/output.txt

Total script time: 7.57 mins

Integration Tests: FAILED

- since resetForm function reset a field value a calculateNow is consequently triggered. But the calculate callback can itself call resetForm, hence an infinite recursive loop. So basically, prevent calculeNow to be triggered by itself. - in Firefox, the letters entered in some fields were duplicated: "AaBb" instead of "AB". It was mainly because beforeInput was triggering a Keystroke which was itself triggering an input value update and then the input event was triggered. So in order to avoid that, beforeInput calls preventDefault and then it's up to the JS to handle the event. - fields have a property valueAsString which returns the value as a string. In the implementation it was wrongly used to store the formatted value of a field (2€ when the user entered 2). So this patch implements correctly valueAsString. - non-rendered fields can be updated in using JS but when they're, they must take some properties in the annotationStorage. It was implemented for field values, but it wasn't for display, colors, ... - it fixes mozilla#14862 and mozilla#14705.

Snuffleupagus · 2022-05-03T13:50:39Z

Also, it seems that the Interaction in 160F-2019.pdf must reset all test is timing out consistently now.

calixteman · 2022-05-03T14:06:51Z

Also, it seems that the Interaction in 160F-2019.pdf must reset all test is timing out consistently now.

It's very likely because of the error you caught (the typeof thing).

calixteman · 2022-05-03T14:07:15Z

/botio integrationtest

pdfjsbot · 2022-05-03T14:07:16Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bd7fc703d48e803/output.txt

pdfjsbot · 2022-05-03T14:07:16Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/555057dcb6e1bc2/output.txt

pdfjsbot · 2022-05-03T14:11:33Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/bd7fc703d48e803/output.txt

Total script time: 4.27 mins

Integration Tests: FAILED

pdfjsbot · 2022-05-03T14:14:55Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/555057dcb6e1bc2/output.txt

Total script time: 7.62 mins

Integration Tests: Passed

calixteman · 2022-05-03T14:15:26Z

/botio unittest

pdfjsbot · 2022-05-03T14:15:27Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/eb696ff51178cdd/output.txt

pdfjsbot · 2022-05-03T14:15:27Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6264bb94f3e52a6/output.txt

pdfjsbot · 2022-05-03T14:18:43Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/eb696ff51178cdd/output.txt

Total script time: 3.23 mins

Unit Tests: Passed

pdfjsbot · 2022-05-03T14:22:02Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/6264bb94f3e52a6/output.txt

Total script time: 6.55 mins

Unit Tests: Passed

…rmittent failures

calixteman · 2022-05-03T14:25:55Z

/botio integrationtest

pdfjsbot · 2022-05-03T14:25:57Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e4ac8f9a3d97084/output.txt

pdfjsbot · 2022-05-03T14:25:57Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b491963cc4639ba/output.txt

pdfjsbot · 2022-05-03T14:30:18Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e4ac8f9a3d97084/output.txt

Total script time: 4.33 mins

Integration Tests: FAILED

pdfjsbot · 2022-05-03T14:33:55Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/b491963cc4639ba/output.txt

Total script time: 7.95 mins

Integration Tests: Passed

calixteman · 2022-05-03T14:55:02Z

@Snuffleupagus, are you still ok with this change ?

calixteman requested a review from Snuffleupagus May 2, 2022 17:54

Snuffleupagus linked an issue May 3, 2022 that may be closed by this pull request

Set Textfield-Value with Javascript not working as expected #14705

Closed

Snuffleupagus added the form-js label May 3, 2022

Snuffleupagus approved these changes May 3, 2022

View reviewed changes

calixteman force-pushed the 14862 branch from 7eb3c0a to 9335af0 Compare May 3, 2022 09:56

calixteman force-pushed the 14862 branch from 9335af0 to 880ee5e Compare May 3, 2022 13:34

Snuffleupagus requested changes May 3, 2022

View reviewed changes

src/scripting_api/doc.js Outdated Show resolved Hide resolved

calixteman force-pushed the 14862 branch from 880ee5e to 094ff38 Compare May 3, 2022 13:48

Add a small delay when typing in some integration tests to avoid inte…

6b866a5

…rmittent failures

calixteman requested a review from Snuffleupagus May 3, 2022 15:09

Snuffleupagus merged commit 8135d7c into mozilla:master May 3, 2022

This was referenced May 4, 2022

Prevent the AnnotationStorage-data from being "silently" modified when using the the getRawValue-method (PR 14869 follow-up) #14872

Closed

Annotation-data exceptions during e.g. printing #14889

Closed

Snuffleupagus mentioned this pull request Aug 17, 2022

Correctly mimic the proper event-format in AnnotationElement._setDefaultPropertiesFromJS (bug 1785218) #15327

Merged

nmtigor mentioned this pull request Sep 20, 2022

Fix bugs #15463

Closed

[JS] Fix few bugs present in the pdf for issue #14862 #14869

[JS] Fix few bugs present in the pdf for issue #14862 #14869

Conversation

calixteman commented May 2, 2022

Snuffleupagus left a comment

Choose a reason for hiding this comment

Snuffleupagus May 3, 2022 • edited

Choose a reason for hiding this comment

calixteman commented May 3, 2022

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Failed

calixteman commented May 3, 2022

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Success

calixteman commented May 3, 2022

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Success

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Failed

Snuffleupagus commented May 3, 2022

calixteman commented May 3, 2022

calixteman commented May 3, 2022

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Success

calixteman commented May 3, 2022

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented May 3, 2022

From: Bot.io (Windows)

Success

calixteman commented May 3, 2022

pdfjsbot commented May 3, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 3, 2022

Snuffleupagus May 3, 2022 •

edited