Re-factor the PresentationMode handling in BaseViewer.#ensurePageViewVisible
#14871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wVisible` Given that we're (ab)using spread-modes in order to ensure that pages are centered *vertically* in PresentationMode, this re-factoring simplifies the code slightly. Furthermore, in the event that we *possibly* want to try and support spread-modes in PresentationMode[1] this re-factoring will also prevent future duplication. --- [1] Note that I'm not particularly keen on doing that, since documents with varying page sizes will be annoying to handle.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0bbe035511dac50/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0bbe035511dac50/output.txt Total script time: 2.74 mins Published |
timvandermeij
approved these changes
May 4, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we're (ab)using spread-modes in order to ensure that pages are centered vertically in PresentationMode, this re-factoring simplifies the code slightly.
Furthermore, in the event that we possibly want to try and support spread-modes in PresentationMode[1] this re-factoring will also prevent future duplication.
[1] Note that I'm not particularly keen on doing that, since documents with varying page sizes will be annoying to handle.