Replace the AnnotationStorage.lastModified-getter with a proper hash-method
#14873
Conversation
Snuffleupagus
force-pushed
the
AnnotationStorage-hash
branch
2 times, most recently
from
690b7f5
to
1541d42
Compare
…h-method The current `lastModified`-getter, which only contains a time-stamp, is a fairly crude way of detecting if the stored data has actually been changed. In particular, when the `getRawValue`-method is used, the `lastModified`-getter doesn't cope with data being modified from the "outside". To fix these issues[1], and to prevent any future bugs in this code, this patch introduces a new `AnnotationStorage.hash`-getter which computes a hash of the currently stored data. To simplify things this re-uses the existing `MurmurHash3_64`-implementation, which required moving that file into the `src/shared/`-folder, since its performance should be good enough here. --- [1] Given how the `AnnotationStorage.lastModified`-getter was used, this would have been limited to *printing* of forms.
Snuffleupagus
force-pushed
the
AnnotationStorage-hash
branch
from
1541d42
to
8267fd8
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0a8a42fb1131385/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3cce35d1d30c114/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0a8a42fb1131385/output.txt Total script time: 26.15 mins
Image differences available at: http://54.241.84.105:8877/0a8a42fb1131385/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3cce35d1d30c114/output.txt Total script time: 30.92 mins
Image differences available at: http://54.193.163.58:8877/3cce35d1d30c114/reftest-analyzer.html#web=eq.log |
|
/botio-windows browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e29f2b328d6bfef/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e29f2b328d6bfef/output.txt Total script time: 23.69 mins
Image differences available at: http://54.193.163.58:8877/e29f2b328d6bfef/reftest-analyzer.html#web=eq.log |
|
Looks good; thanks! |
The current
lastModified-getter, which only contains a time-stamp, is a fairly crude way of detecting if the stored data has actually been changed. In particular, when thegetRawValue-method is used, thelastModified-getter doesn't cope with data being modified from the "outside".To fix these issues[1], and to prevent any future bugs in this code, this patch introduces a new
AnnotationStorage.hash-getter which computes a hash of the currently stored data. To simplify things this re-uses the existingMurmurHash3_64-implementation, which required moving that file into thesrc/shared/-folder, since its performance should be good enough here.[1] Given how the
AnnotationStorage.lastModified-getter was used, this would have been limited to printing of forms.