-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TrueType format 12 cmap
s (issue 14881)
#14882
Conversation
This is, as far as I can tell, the first case we've seen of a format 12 `cmap`. Please see https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6cmap.html
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1c5dfd3a61d10d9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e2c6d4c4ba1e278/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1c5dfd3a61d10d9/output.txt Total script time: 26.14 mins
Image differences available at: http://54.241.84.105:8877/1c5dfd3a61d10d9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e2c6d4c4ba1e278/output.txt Total script time: 31.15 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6784e6ab3f85701/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6784e6ab3f85701/output.txt Total script time: 2.67 mins Published |
Thank you for implementing this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b91499d816fb2cf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/697a5a7af381a44/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b91499d816fb2cf/output.txt Total script time: 23.30 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/697a5a7af381a44/output.txt Total script time: 24.73 mins
|
@timvandermeij Thanks a lot for reviewing/merging my patches! A possible follow-up here could be to add support for format 13 Based on the specification text it seems to me that format 13 might be quite rare, and I'd not be able to supply a test-case, but do you think that it'd make sense to add support for those |
Given the "[...] used internally by Apple for its last resort font and by Unicode's last resort font. It would, in general, not be appropriate for any font other than a last resort font" part of the specification, I don't really think we'll see it in practice. Moreover, I think it's good to only implement this if we actually have a file that uses it, otherwise it will be hard to verify the correctness of the implementation and we won't have a regression test. For now I'd say we don't implement this until we actually find/make a file with format 13 |
This is, as far as I can tell, the first case we've seen of a format 12
cmap
.Please see https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6cmap.html