Simplify the "fileattachmentannotation"-event handling a little bit #14884
Conversation
*This patch can be tested, in the viewer, using the `annotation-fileattachment.pdf` document from the test-suite.* Note how the `FileSpec`-implementation already uses `stringToPDFString` during the filename lookup, see https://github.com/mozilla/pdf.js/blob/cfac6fa511945ae5b75d3c27a9356527862a7bf6/src/core/file_spec.js#L70 Hence there's no reason to repeat that again in the `FileAttachmentAnnotationElement`-constructor, and we can thus simplify the "fileattachmentannotation"-event handling a little bit.
Snuffleupagus
force-pushed
the
fileattachmentannotation-event
branch
from
0d15b8b
to
7f40ef4
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1405e641075a0fc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a1c2f0cd921ba5c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1405e641075a0fc/output.txt Total script time: 4.37 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a1c2f0cd921ba5c/output.txt Total script time: 7.88 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c67278d9bf0c982/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c67278d9bf0c982/output.txt Total script time: 2.69 mins Published |
|
Thanks! |
This patch can be tested, in the viewer, using the
annotation-fileattachment.pdfdocument from the test-suite.Note how the
FileSpec-implementation already usesstringToPDFStringduring the filename lookup, seepdf.js/src/core/file_spec.js
Line 70 in cfac6fa
Hence there's no reason to repeat that again in the
FileAttachmentAnnotationElement-constructor, and we can thus simplify the "fileattachmentannotation"-event handling a little bit.