Stop bundling PDFViewerApplication.{unbindEvents, unbindWindowEvents} in MOZCENTRAL builds
#14885
Conversation
…}` in MOZCENTRAL builds
These methods are completely unused in the Firefox PDF Viewer, and were only added to supplement the `PDFViewerApplication.{bindEvents, bindWindowEvents}`-methods since third-party implementations may apparently need to remove event listeners (see PR 8525).
However, in the MOZCENTRAL build that's just dead code and this patch reduces the size of the *built* `web/viewer.js`-file by `~3.5` kB.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bad05117371a5a7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1a166421ff76778/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/bad05117371a5a7/output.txt Total script time: 3.88 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1a166421ff76778/output.txt Total script time: 4.42 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/60015e0b07f3e23/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/60015e0b07f3e23/output.txt Total script time: 2.66 mins Published |
|
Thanks! |
These methods are completely unused in the Firefox PDF Viewer, and were only added to supplement the
PDFViewerApplication.{bindEvents, bindWindowEvents}-methods since third-party implementations may apparently need to remove event listeners (see PR #8525).However, in the MOZCENTRAL build that's just dead code and this patch reduces the size of the built
web/viewer.js-file by~3.5kB.