Try to fix dispatching of "attachmentsloaded"-events, when the document contains no "regular" attachments (PR 8788, 12163 follow-up) #14888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
attachmentsCount-zero
branch
from
6d09dd5
to
262ec82
Compare
…nt contains no "regular" attachments (PR 8788, 12163 follow-up) *This patch can be tested, in the viewer, using the `annotation-fileattachment.pdf` document from the test-suite.* It seems that the code to delay dispatching of the "attachmentsloaded"-event, when `attachmentsCount === 0`, is now effectively broken.[1] Rather than only using an arbitrary timeout, the new code will instead wait for an "annotationlayerrendered"-event and only *fallback* to using a timeout. --- [1] The timing of the annotationLayer-rendering changed slightly in PR 14247, and the old code in `PDFAttachmentViewer` wasn't good enough to handle that.
Snuffleupagus
force-pushed
the
attachmentsCount-zero
branch
from
262ec82
to
dacea52
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/940c7896a8140d2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/940c7896a8140d2/output.txt Total script time: 2.61 mins Published |
timvandermeij
approved these changes
May 8, 2022
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch can be tested, in the viewer, using the
annotation-fileattachment.pdfdocument from the test-suite.It seems that the code to delay dispatching of the "attachmentsloaded"-event, when
attachmentsCount === 0, is now effectively broken.[1]Rather than only using an arbitrary timeout, the new code will instead wait for an "annotationlayerrendered"-event and only fallback to using a timeout.
[1] The timing of the annotationLayer-rendering changed slightly in PR #14247, and the old code in
PDFAttachmentViewerwasn't good enough to handle that.