[JS] Formatted value has to be a string when neither null nor undefined

[calixteman]

No description provided.

[Snuffleupagus]

Would it make sense to also add a ... || value === null check to the following block, to prevent a possible future bug?

pdf.js/src/core/annotation.js

Line 1523 in 72943ae

if (value === undefined) {

Or, if that's not correct, how about a if (value === null) { return ""; } check just before

pdf.js/src/core/annotation.js

Line 1535 in 72943ae

value = value.trim();

[calixteman]

The issue here was due to a formatted value which was a number (so no trim method).
The stored value shouldn't be null:

pdf.js/src/display/annotation_layer.js

Line 961 in 72943ae

storage.setValue(id, { value: event.target.value });

pdf.js/src/display/annotation_layer.js

Line 997 in 72943ae

storage.setValue(id, { value: elementData.userValue.toString() });

The call to trim is a kind of assertion that the value is a string (and thx to that we caught the error you reported).
Maybe we can be more explicit and add an assertion to check the type of value, wdyt ?

[Snuffleupagus]

Maybe we can be more explicit and add an assertion to check the type of value, wdyt ?

That might be the nicest solution; since an explicit error is always better than an implicit one.

[Snuffleupagus]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bf24429f36bd3bb/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/bf24429f36bd3bb/output.txt

Total script time: 2.57 mins

Published

• Viewer: http://54.241.84.105:8877/bf24429f36bd3bb/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/bf24429f36bd3bb/legacy/web/viewer.html

[Snuffleupagus]

r=me, with passing tests; thank you!

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9a33fb322b964e0/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d136a7983980082/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/d136a7983980082/output.txt

Total script time: 25.85 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 6

Image differences available at: http://54.241.84.105:8877/d136a7983980082/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/9a33fb322b964e0/output.txt

Total script time: 31.86 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/9a33fb322b964e0/reftest-analyzer.html#web=eq.log