Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotation] A push button can have no action (bug 1778692) #15153

Merged
merged 1 commit into from Jul 8, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

Comment on lines 1443 to 1444
if (this.enableScripting && this.hasJSActions && container.lastChild) {
const linkElement = container.lastChild;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we could, ever so slightly, simplify things by getting the element just once:

Suggested change
if (this.enableScripting && this.hasJSActions && container.lastChild) {
const linkElement = container.lastChild;
const linkElement = container.lastChild;
if (linkElement && this.enableScripting && this.hasJSActions) {

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4206ac00333a622/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5b2e9742bbe9791/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/5b2e9742bbe9791/output.txt

Total script time: 26.41 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 19

Image differences available at: http://54.241.84.105:8877/5b2e9742bbe9791/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/4206ac00333a622/output.txt

Total script time: 28.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/4206ac00333a622/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 2b6a67c into mozilla:master Jul 8, 2022
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c98ef4cb509171/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f6e602956c04184/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/9c98ef4cb509171/output.txt

Total script time: 22.47 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/f6e602956c04184/output.txt

Total script time: 22.57 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants